From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Konstantin Osipov <kostja@tarantool.org>,
tarantool-patches@freelists.org, commits@tarantool.org
Subject: Re: [commits] [tarantool] 03/04: bloom: optimize tuple bloom filter size
Date: Wed, 28 Mar 2018 20:19:30 +0300 [thread overview]
Message-ID: <20180328171930.7n37ebb4ihvh5hjx@esperanza> (raw)
In-Reply-To: <20180328170348.GK11829@atlas>
On Wed, Mar 28, 2018 at 08:03:48PM +0300, Konstantin Osipov wrote:
> * Vladimir Davydov <vdavydov.dev@gmail.com> [18/03/28 14:50]:
> > >
> > > In future, It would be nice to actually have stats about actual false
> > > positive rates so that we know if the papers are BS or not.
> >
> > We already have bloom.hit and bloom.miss stat counters in index.info()
> > so we can calculate the false positive rate as
> >
> > bloom.miss / (bloom.hit + bloom.miss)
>
> Do you have a test verifying that the formula works?
vinyl/bloom.test.lua uses these stats to check that observed false
positive rate doesn't exceed the configured value.
next prev parent reply other threads:[~2018-03-28 17:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-27 21:08 [commits] [tarantool] 02/04: vinyl: introduce bloom filters for partial key lookups Konstantin Osipov
[not found] ` <20180327210938.GC11829@atlas>
2018-03-28 11:16 ` [commits] [tarantool] 03/04: bloom: optimize tuple bloom filter size Vladimir Davydov
2018-03-28 17:03 ` Konstantin Osipov
2018-03-28 17:19 ` Vladimir Davydov [this message]
2018-03-28 11:58 ` [commits] [tarantool] 02/04: vinyl: introduce bloom filters for partial key lookups Vladimir Davydov
2018-03-28 17:03 ` Konstantin Osipov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180328171930.7n37ebb4ihvh5hjx@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=commits@tarantool.org \
--cc=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [commits] [tarantool] 03/04: bloom: optimize tuple bloom filter size' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox