From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Kirill Shcherbatov <kshcherbatov@tarantool.org>
Cc: v.shpilevoy@tarantool.org, tarantool-patches@freelists.org
Subject: Re: [tarantool-patches] Re: [PATCH v2 1/1] tuple:tomap: only_names option
Date: Wed, 28 Mar 2018 13:20:52 +0300 [thread overview]
Message-ID: <20180328102052.c5vrvozwvdjpvscy@esperanza> (raw)
In-Reply-To: <50FD81D5-916C-4E8C-B32B-1234729D0B40@tarantool.org>
Ack, but please in future add more descriptive comments to your patches.
In this particular case it would be nice to have a description of the
new option in the commit log (what it does, an example of usage).
> From 14a62b394bf7b21d6c9549875abce5c71416c0b3 Mon Sep 17 00:00:00 2001
> From: Kirill Shcherbatov <kshcherbatov@tarantool.org>
> Date: Wed, 28 Mar 2018 11:05:19 +0300
> Subject: [PATCH] tuple:tomap: only_names option
>
> Fixes #3280
>
> src/box/lua/tuple.c | 22 +++++++++++++--
> test/engine/tuple.result | 69 ++++++++++++++++++++++++++++++++++++++++++++++
> test/engine/tuple.test.lua | 21 ++++++++++++++
> 3 files changed, 110 insertions(+), 2 deletions(-)
next prev parent reply other threads:[~2018-03-28 10:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <b9c53caf-7c00-6bef-3e90-c71f519553fe@tarantool.org>
2018-03-27 15:00 ` [tarantool-patches] " Kirill Shcherbatov
2018-03-27 15:34 ` [tarantool-patches] " v.shpilevoy
2018-03-28 8:01 ` Kirill Shcherbatov
2018-03-28 8:05 ` Kirill Shcherbatov
2018-03-28 8:16 ` v.shpilevoy
2018-03-28 10:20 ` Vladimir Davydov [this message]
2018-03-27 10:06 [tarantool-patches] " Kirill Shcherbatov
2018-03-27 10:14 ` [tarantool-patches] " v.shpilevoy
2018-03-27 10:28 ` Kirill Shcherbatov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180328102052.c5vrvozwvdjpvscy@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=kshcherbatov@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [tarantool-patches] Re: [PATCH v2 1/1] tuple:tomap: only_names option' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox