Re: [tarantool-patches] Re: [PATCH v2 1/1] netbox: show is_nullable and collation fields

[Vladimir Davydov <vdavydov.dev@gmail.com>]

On Mon, Mar 26, 2018 at 08:41:21PM +0300, Kirill Shcherbatov wrote:
> diff --git a/test/box/net.box.test.lua b/test/box/net.box.test.lua
> index fe45721..3b4ce05 100644
> --- a/test/box/net.box.test.lua
> +++ b/test/box/net.box.test.lua
> @@ -799,11 +799,9 @@
> box.schema.user.revoke('guest','read,write,execute','universe')
> 
>  space:drop()
> 
> -
>  --
>  -- gh-3256 net.box is_nullable and collation options output
>  --
> -
>  space = box.schema.create_space('test')
>  box.schema.user.grant('guest','read,write,execute','space', 'test')
>  pk = space:create_index('pk')
> @@ -821,4 +819,5 @@ c = net:connect(box.cfg.listen)
>  c.space.test.index.sk.parts
>  c:close()
>  box.internal.collation.drop('test')
> -space:drop()
> \ No newline at end of file
> +space:drop()
> +

Nit-pick: extra newline at the end of the file. We always add exactly
one newline symbol at the end of each source file. In v1 you added no
newline at all, in v2 you added two newline symbols. Please fix your
editor configuration.

Other than that, the patch is fine by me.