From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Georgy Kirichenko <georgy@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: Re: [PATCH] Clear session storage on session stop
Date: Tue, 27 Mar 2018 18:32:03 +0300 [thread overview]
Message-ID: <20180327153203.x7h55y5ohcialqgs@esperanza> (raw)
In-Reply-To: <6f3087cb542e9a56f53730a2638686ce2e333527.1522156730.git.georgy@tarantool.org>
Looks good to me.
On Tue, Mar 27, 2018 at 04:29:14PM +0300, Georgy Kirichenko wrote:
> * session_run_on_disconnect_triggers is called only if there are
> corresponding triggers so move session_storage_cleanup to
> session_destroy.
> * fix session storage cleanup path: use
> "box.session.aggregate_storage[sid]" instead of
> "session.aggregate_storage[sid]" (what was wrong)
>
> Fixed #3279
> ---
> https://github.com/tarantool/tarantool/tree/gh-3279-clear-session-storage
>
> src/box/lua/session.c | 3 +++
> src/box/session.cc | 2 +-
> test/box-tap/session.storage.test.lua | 2 +-
> 3 files changed, 5 insertions(+), 2 deletions(-)
prev parent reply other threads:[~2018-03-27 15:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-27 13:29 Georgy Kirichenko
2018-03-27 15:32 ` Vladimir Davydov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180327153203.x7h55y5ohcialqgs@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=georgy@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [PATCH] Clear session storage on session stop' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox