[tarantool-patches] [kostja@tarantool.org: Re: [PATCH v2 1/2] Introduce 'view' space option]

[tarantool-patches] [kostja@tarantool.org: Re: [PATCH v2 1/2] Introduce 'view' space option]

[Konstantin Osipov]

----- Forwarded message from Konstantin Osipov <kostja@tarantool.org> -----

Date: Tue, 27 Mar 2018 09:02:56 +0300
From: Konstantin Osipov <kostja@tarantool.org>
To: tarantool-patches@freelists.org
Cc: tarantool-patches@freelist.org, Nikita Pettik <korablev@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v2 1/2] Introduce 'view' space option

* Nikita Pettik <korablev@tarantool.org> [18/03/27 02:06]:
> +	if (opts.view && opts.sql == NULL) {
> +		tnt_raise(ClientError, ER_VIEW_MISSING_SQL);
> +	}

We usually do not add {} braces around one-line if bodies.

>  	struct space_def *def =
>  		space_def_new_xc(id, uid, exact_field_count, name, name_len,
>  				 engine_name, engine_name_len, &opts, fields,
> @@ -1590,6 +1593,10 @@ on_replace_dd_index(struct trigger * /* trigger */, void *event)
>  	uint32_t iid = tuple_field_u32_xc(old_tuple ? old_tuple : new_tuple,
>  					  BOX_INDEX_FIELD_ID);
>  	struct space *old_space = space_cache_find_xc(id);
> +	if (old_space->def->opts.view) {
> +		tnt_raise(ClientError, ER_ALTER_SPACE, space_name(old_space),
> +			  "can not alter indexes on view");
> +	}

can not add index on a view.

You know for sure it's add, since it can't be drop or modify,
so let's the error message more specific.

You can also introduce a separate error code for the purpose,
ER_ALTER_VIEW.

>  const struct space_opts space_opts_default = {
>  	/* .temporary = */ false,
> +	/* .view = */ false,
>  	/* .sql        = */ NULL,
>  };

is_view. Usually we add is_  or has_ prefix to boolean state
variables.

> +	if (new_def->opts.view != old_def->opts.view) {
> +		diag_set(ClientError, ER_ALTER_SPACE, old_def->name,
> +			 "can not transform space to view and visa versa");
> +		return -1;
> +	}

can't convert a space to a view or vice vice versa.

In future, please check all error messages you add with Elena.


-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.org - www.twitter.com/kostja_osipov


----- End forwarded message -----

-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.org - www.twitter.com/kostja_osipov