From: Alexander Turenko <alexander.turenko@tarantool.org> To: Ivan Ilyin <vanyail@yandex.ru>, tarantool-patches@freelists.org Cc: Nikita Pettik <korablev@tarantool.org>, Kirill Yukhin <kyukhin@tarantool.org> Subject: [tarantool-patches] Re: [PATCH] sql: ban of REINDEX syntax Date: Wed, 21 Mar 2018 23:10:31 +0300 [thread overview] Message-ID: <20180321201031.gqoyg4mf2mb3q6sj@tkn_work_nb> (raw) In-Reply-To: <20180321164252.iiwzs23vgn6srtl5@tarantool.org> Ivan, please consider decisions below, update the commit and send it again. WBR, Alexander Turenko. On Wed, Mar 21, 2018 at 07:42:52PM +0300, Kirill Yukhin wrote: > On 21 мар 19:08, Alexander Turenko wrote: > > Kirill, can you suggest best ways to go forward on detable questions > > below? > I think there're no specific ways to raise such. If you'd like to bring > my attention: CC me explicitly in e-mail. > > > > > On Wed, Mar 21, 2018 at 06:37:38PM +0300, n.pettik wrote: > > > Hello. See comments below. > > > > > > >This change cut > > > > > > Misspelling: cut(s). > > > > > > >The reason described in 'parse.y' in comment related > > > >to '%fallback'. > > > > > > Don't reffer to comments in your commit message. Instead, provide > > > short desctiption/explanation. > > > > > > > Why we need to duplicate explanation? A commit message is a part of the > > commit. > You might break commit-comment connection by commits that follows. > Proposed to describe it shortly in the commit message like so: Note that REINDEX keyword is still in '%fallback' directive in 'parse.y', because we need at least one usage of a keyword in 'parse.y' to prevent exclusion from 'parse.h' (it would break the build). > > > >+++ b/src/box/sql/parse.y > > > >@@ -202,6 +202,17 @@ columnname(A) ::= nm(A) typetoken(Y). {sqlite3AddColumn(pParse,&A,&Y);} > > > >// fallback to ID if they will not parse as their original value. > > > >// This obviates the need for the "id" nonterminal. > > > >// > > > >+// A keyword is checked for being a reserve one in `nm`, before > > > >+// processing of this %fallback directive. Reserved keywords included > > > >+// here to avoid the situation when a keyword has no usages within > > > >+// `parse.y` file (a keyword can have more or less usages depending on > > > >+// compiler defines). When a keyword has no usages it is excluded > > > >+// from autogenerated file `parse.h` that lead to compile-time error. > > > >+// > > > >+// See [1] for more information. > > > >+// > > > >+// [1]: https://www.sqlite.org/src/info/007aec11333432e0 > > > >+// > > > > > > I would better put link to commit message or to comments of original > > > issue. I stick to the point that source code doesn't seem to be good > > > place for links. Also, in Tarantool we use C-like commenting style. > > > > > > > I don't see nothing bad with using links, epsecially when it can > > simplify reader experience. > IMHO, internet is volatile. WWW-links are not verbatim enough to me, and > hence are fallcious artifacts to put into comment. I'd defer final decision > to 1st level reviewer. > Link with SHA1 is better IMO than just SHA1, but I understood that the point is about our feelings of the code we write. Proposed to include it like so: See fossil check-in [007aec11] or CVS commit 2045 in SQLite for more information.
prev parent reply other threads:[~2018-03-21 20:10 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <1521051043-28203-1-git-send-email-vanyail@yandex.ru> 2018-03-15 13:34 ` [tarantool-patches] Re: [patches] [PATCH] Ban " Alexander Turenko 2018-03-15 13:56 ` [tarantool-patches] Re[2]: " Alexander Turenko 2018-03-19 19:22 ` [tarantool-patches] [PATCH] sql: ban " Ivan Ilyin 2018-03-21 11:06 ` Ivan Ilyin 2018-03-21 13:02 ` [tarantool-patches] " Alexander Turenko 2018-03-21 15:37 ` n.pettik 2018-03-21 16:08 ` Alexander Turenko 2018-03-21 16:42 ` Kirill Yukhin 2018-03-21 20:10 ` Alexander Turenko [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180321201031.gqoyg4mf2mb3q6sj@tkn_work_nb \ --to=alexander.turenko@tarantool.org \ --cc=korablev@tarantool.org \ --cc=kyukhin@tarantool.org \ --cc=tarantool-patches@freelists.org \ --cc=vanyail@yandex.ru \ --subject='[tarantool-patches] Re: [PATCH] sql: ban of REINDEX syntax' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox