From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: "v.shpilevoy@tarantool.org" <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: Re: [tarantool-patches] Re: [PATCH 3/5] Remove empty function declaration
Date: Wed, 21 Mar 2018 12:16:59 +0300 [thread overview]
Message-ID: <20180321091659.2bl4l4xwhdhta4qf@esperanza> (raw)
In-Reply-To: <2AEEC274-1D72-4473-9F1B-C97DEBECD4A2@tarantool.org>
On Tue, Mar 20, 2018 at 08:57:53PM +0300, v.shpilevoy@tarantool.org wrote:
>
>
> > 20 марта 2018 г., в 20:55, Vladimir Davydov <vdavydov.dev@gmail.com> написал(а):
> >
> > On Mon, Mar 19, 2018 at 04:34:50PM +0300, Vladislav Shpilevoy wrote:
> >> diff --git a/src/lua/socket.h b/src/lua/socket.h
> >> index f669b5ada..ec4e79d87 100644
> >> --- a/src/lua/socket.h
> >> +++ b/src/lua/socket.h
> >> @@ -45,8 +45,6 @@ lbox_socket_local_resolve(const char *host, const char *port,
> >> struct sockaddr *addr, socklen_t *socklen);
> >> int
> >> lbox_socket_nonblock(int fh, int mode);
> >> -int bsdsocket_sendto(int fh, const char *host, const char *port,
> >> - const void *octets, size_t len, int flags);
> >
> > The patch is OK, obviously, but it doesn't belong to this series.
> > Please submit irrelevant changes like this one separately.
> >
>
> Do you propose to push it on a different branch?
I don't think we need to do this now. Let's just push this trivial patch
to the trunk so that you can drop it from the series in v2.
next prev parent reply other threads:[~2018-03-21 9:16 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-19 13:34 [PATCH 0/5] session: introduce box.session.push Vladislav Shpilevoy
2018-03-19 13:34 ` [PATCH 1/5] session: forbid creation from Lua binary and applier sessions Vladislav Shpilevoy
2018-03-20 13:20 ` Vladimir Davydov
2018-03-20 13:46 ` v.shpilevoy
2018-03-19 13:34 ` [PATCH 2/5] lua: port console yaml formatting to C Vladislav Shpilevoy
2018-03-20 17:51 ` Vladimir Davydov
2018-03-20 18:04 ` v.shpilevoy
2018-03-21 9:14 ` Vladimir Davydov
2018-03-21 9:30 ` v.shpilevoy
2018-03-19 13:34 ` [PATCH 3/5] Remove empty function declaration Vladislav Shpilevoy
2018-03-20 17:55 ` Vladimir Davydov
2018-03-20 17:57 ` [tarantool-patches] " v.shpilevoy
2018-03-21 9:16 ` Vladimir Davydov [this message]
2018-03-19 13:34 ` [PATCH 4/5] session: introduce session_owner Vladislav Shpilevoy
2018-03-20 18:29 ` Vladimir Davydov
2018-03-19 13:34 ` [PATCH 5/5] session: introduce box.session.push Vladislav Shpilevoy
2018-03-21 9:10 ` Vladimir Davydov
2018-03-21 9:30 ` [tarantool-patches] " v.shpilevoy
2018-03-21 12:25 ` Vladimir Davydov
2018-03-19 13:41 ` [tarantool-patches] [PATCH 0/5] " v.shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180321091659.2bl4l4xwhdhta4qf@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [tarantool-patches] Re: [PATCH 3/5] Remove empty function declaration' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox