Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: Re: [PATCH v2 0/2] vinyl: in a task use copy of index key defs to protect from alter
Date: Tue, 20 Mar 2018 16:13:28 +0300	[thread overview]
Message-ID: <20180320131328.6kta3736xkejtv7f@esperanza> (raw)
In-Reply-To: <cover.1521116161.git.v.shpilevoy@tarantool.org>

Looks good to me.

On Thu, Mar 15, 2018 at 03:19:14PM +0300, Vladislav Shpilevoy wrote:
> Branch: http://github.com/tarantool/tarantool/tree/gh-3229-space-format-enables-optional-v2
> Issue: https://github.com/tarantool/tarantool/issues/3229
> 
> A vinyl space can be altered in such a way, that key definitions
> of indexes are not changed, but comparators do. It is because
> space format reset can make some indexed fields optional.
> 
> To be able update key definitions in place, they must not be used
> in a worker thread. So lets copy key_defs for a worker, and
> update index key definitions in place.
> 
> An alternative is key_defs reference counting, but there is open
> questions what to do in key_defs in mems, ranges, iterators,
> runs, slices. Now lets do a hotfix of a crash, and then
> refactoring.
> 
> Vladislav Shpilevoy (2):
>   Do not mix box_key_def_delete and free to delete key_def
>   vinyl: in a task use copy of index key defs to protect from alter
> 
>  src/box/alter.cc                |  3 ++-
>  src/box/key_def.cc              | 10 ++++++++--
>  src/box/key_def.h               |  7 +++++++
>  src/box/schema.cc               |  4 ++--
>  src/box/vinyl.c                 | 10 ++++++++--
>  src/box/vy_index.c              |  8 ++++----
>  src/box/vy_scheduler.c          | 25 ++++++++++++++++++++++---
>  test/engine/ddl.result          |  2 +-
>  test/engine/ddl.test.lua        |  2 +-
>  test/unit/vy_iterators_helper.c |  2 +-
>  test/unit/vy_mem.c              |  4 ++--
>  test/unit/vy_point_lookup.c     |  2 +-
>  test/unit/vy_write_iterator.c   |  2 +-
>  13 files changed, 60 insertions(+), 21 deletions(-)

  parent reply	other threads:[~2018-03-20 13:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-15 12:19 Vladislav Shpilevoy
2018-03-15 12:19 ` [PATCH v2 1/2] Do not mix box_key_def_delete and free to delete key_def Vladislav Shpilevoy
2018-03-15 12:19 ` [PATCH v2 2/2] vinyl: in a task use copy of index key defs to protect from alter Vladislav Shpilevoy
2018-03-16 13:00 ` [PATCH v2 0/2] " Vladimir Davydov
2018-03-20 13:13 ` Vladimir Davydov [this message]
2018-03-20 13:18   ` v.shpilevoy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180320131328.6kta3736xkejtv7f@esperanza \
    --to=vdavydov.dev@gmail.com \
    --cc=tarantool-patches@freelists.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [PATCH v2 0/2] vinyl: in a task use copy of index key defs to protect from alter' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox