Re: [Tarantool-patches] [PATCH vshard 2/2] storage: introduce vshard.storage._call()

[Oleg Babin <olegrok@tarantool.org>]

Thanks for your patch! See comments bellow.

On 21/03/2020 21:59, Vladislav Shpilevoy wrote:
> _call can't be properly integrated at this moment, because that
> would break rebalancing from old nodes. The new function is only
> added. Its usage and drop of old functions will happen in 0.1.17
> when I will finish and merge top commit from this branch:
> https://github.com/tarantool/vshard/tree/gerold103/gh-227-drop-old-functions

Could you add some "smoke" tests for "_call" function? The test in this 
patch only checks that it exists but don't check that it works. If it's 
hard and non-trivial ignore this comment.

>   
> +local service_call_api = {
> +    bucket_recv = bucket_recv,
> +    rebalancer_apply_routes = rebalancer_apply_routes,
> +    rebalancer_request_state = rebalancer_request_state,
> +}
> +
> +local function service_call(...)
> +    local service_name = select(1, ...)
> +    return service_call_api[service_name](select(2, ...))
> +end

What's about checking that "service_call_api[service_name]" exists?