Re: [Tarantool-patches] [v2][PATCH 5/5] ci: add job with build using Ninja on linux-x86_64

[Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Igor, thanks for review!

On 15.06.2022 11:48, Igor Munkin wrote:
> Sergey,
>
> Thanks for the patch! LGTM as trivial, but please consider nits below.
>
> On 06.06.22, Sergey Bronnikov wrote:
<snipped>
>> +
>> +jobs:
>> +  test-linux-x86_64:
>> +    runs-on: ubuntu-20.04-self-hosted
>> +    strategy:
>> +      fail-fast: false
>> +    name: Linux/x86_64 ${{ matrix.BUILDTYPE }}
> There is no testing matrix, so you can just name the workflow kinda
> "Linux/x86_64 Ninja".
Renamed to "Linux/x86_64 Ninja".
>> +    steps:
>> +      - uses: actions/checkout@v2.3.4
>> +        with:
>> +          fetch-depth: 0
>> +          submodules: recursive
>> +      - name: setup
>> +        run: |
>> +          sudo apt -y update
>> +          sudo apt -y install cmake ninja-build gcc perl
>> +      - name: configure
>> +        run: cmake . -DCMAKE_BUILD_TYPE=RelWithDebInfo -G Ninja
>> +      - name: build
>> +        run: cmake --build . -j $(nproc)
>> +      - name: test
>> +        run: cmake --build . -j $(nproc) -t test
> Please, use long options, as we discussed here[1].


Fixed:

--- a/.github/workflows/linux-x86_64-ninja.yml
+++ b/.github/workflows/linux-x86_64-ninja.yml
@@ -44,6 +44,6 @@ jobs:
        - name: configure
          run: cmake . -DCMAKE_BUILD_TYPE=RelWithDebInfo -G Ninja
        - name: build
-        run: cmake --build . -j $(nproc)
+        run: cmake --build . --parallel $(($(nproc) + 1))
        - name: test
-        run: cmake --build . -j $(nproc) -t test
+        run: cmake --build . --parallel $(($(nproc) + 1)) --target test

>
>> -- 
>> 2.25.1
>>
> [1]: https://lists.tarantool.org/tarantool-patches/YpjeijSClWO0v82Y@tarantool.org/
>