Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Kirill Shcherbatov <kshcherbatov@tarantool.org>,
	tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH v6 0/4] sql: moved Checks to server
Date: Wed, 16 May 2018 14:52:40 +0300	[thread overview]
Message-ID: <1e67c524-f635-15ce-7a89-b3341c4caa9b@tarantool.org> (raw)
In-Reply-To: <cover.1526403792.git.kshcherbatov@tarantool.org>

Hello. Thanks for the patchset! Please, describe what it does, why and how.

On 15/05/2018 20:03, Kirill Shcherbatov wrote:
> Branch: http://github.com/tarantool/tarantool/tree/gh-3272-no-sql-checks
> Issue: https://github.com/tarantool/tarantool/issues/3272
> 
> Kirill Shcherbatov (4):
>    sql: fix code style in sqlite3Pragma
>    sql: remove SQL fields from Table and Column
>    sql: space_def* instead of Table* in Expr
>    sql: remove Checks to server
> 
>   src/box/alter.cc            |  11 +
>   src/box/field_def.c         |   1 +
>   src/box/field_def.h         |  20 ++
>   src/box/key_def.cc          |   2 +-
>   src/box/opt_def.c           |  16 +-
>   src/box/opt_def.h           |   8 +-
>   src/box/space_def.c         | 135 +++++++++--
>   src/box/space_def.h         |  24 ++
>   src/box/sql.c               | 225 +++++++++++++++---
>   src/box/sql.h               | 125 +++++++++-
>   src/box/sql/alter.c         |  59 +++--
>   src/box/sql/analyze.c       |  18 +-
>   src/box/sql/build.c         | 553 +++++++++++++++++++++++---------------------
>   src/box/sql/delete.c        |  31 +--
>   src/box/sql/expr.c          | 215 ++++++++---------
>   src/box/sql/fkey.c          |  71 +++---
>   src/box/sql/hash.c          |  10 +-
>   src/box/sql/hash.h          |   2 +-
>   src/box/sql/insert.c        | 138 ++++++-----
>   src/box/sql/parse.y         |  86 +++----
>   src/box/sql/pragma.c        |  96 ++++----
>   src/box/sql/pragma.h        |   2 -
>   src/box/sql/prepare.c       |  52 +++--
>   src/box/sql/resolve.c       |  71 +++---
>   src/box/sql/select.c        | 245 ++++++++++++--------
>   src/box/sql/sqliteInt.h     |  81 ++-----
>   src/box/sql/tokenize.c      |  12 +-
>   src/box/sql/treeview.c      |   2 +-
>   src/box/sql/trigger.c       |  20 +-
>   src/box/sql/update.c        |  60 ++---
>   src/box/sql/util.c          |   9 -
>   src/box/sql/vdbe.c          |  28 +--
>   src/box/sql/vdbeaux.c       |  34 ---
>   src/box/sql/vdbemem.c       |  18 +-
>   src/box/sql/where.c         |  27 ++-
>   src/box/sql/wherecode.c     |  53 +++--
>   src/box/sql/whereexpr.c     |  19 +-
>   test/sql-tap/check.test.lua |  13 +-
>   38 files changed, 1540 insertions(+), 1052 deletions(-)
> 

  parent reply	other threads:[~2018-05-16 11:52 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-15 17:03 [tarantool-patches] " Kirill Shcherbatov
2018-05-15 17:03 ` [tarantool-patches] [PATCH v6 1/4] sql: fix code style in sqlite3Pragma Kirill Shcherbatov
2018-05-15 17:03 ` [tarantool-patches] [PATCH v6 2/4] sql: remove SQL fields from Table and Column Kirill Shcherbatov
2018-05-17 17:25   ` [tarantool-patches] " n.pettik
2018-05-18 15:35     ` Kirill Shcherbatov
2018-05-18 17:24       ` n.pettik
2018-05-18 19:45         ` Kirill Shcherbatov
2018-05-18 20:13           ` n.pettik
2018-05-15 17:03 ` [tarantool-patches] [PATCH v6 3/4] sql: space_def* instead of Table* in Expr Kirill Shcherbatov
2018-05-16 12:33   ` [tarantool-patches] " Vladislav Shpilevoy
2018-05-16 13:10     ` Kirill Shcherbatov
2018-05-16 13:11       ` Vladislav Shpilevoy
     [not found]   ` <26E4269B-2BCB-42C3-8216-D51E290E4723@corp.mail.ru>
2018-05-18 15:26     ` Kirill Shcherbatov
2018-05-18 17:04       ` n.pettik
2018-05-21 12:48       ` [tarantool-patches] " Nikita Pettik
2018-05-15 17:03 ` [tarantool-patches] [PATCH v6 4/4] sql: remove Checks to server Kirill Shcherbatov
2018-05-16 17:59   ` [tarantool-patches] " Vladislav Shpilevoy
2018-05-16 11:52 ` Vladislav Shpilevoy [this message]
2018-05-16 13:13   ` [tarantool-patches] Re: [PATCH v6 0/4] sql: moved " Kirill Shcherbatov
2018-05-23  5:19 ` Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1e67c524-f635-15ce-7a89-b3341c4caa9b@tarantool.org \
    --to=v.shpilevoy@tarantool.org \
    --cc=kshcherbatov@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH v6 0/4] sql: moved Checks to server' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox