Re: [Tarantool-patches] [PATCH] sql: fix number and boolean sorting rules

["Timur Safin" <tsafin@tarantool.org>]

: -----Original Message-----
: From: Roman Khabibov <roman.habibov@tarantool.org>
: Sent: Friday, April 17, 2020 2:25 PM
: To: Timur Safin <tsafin@tarantool.org>
: Cc: Mergen Imeev <imeevma@tarantool.org>; tarantool-
: patches@dev.tarantool.org
: Subject: Re: [PATCH] sql: fix number and boolean sorting rules
: 
: Hi! Thanks for the review.
: 
: > On Apr 17, 2020, at 10:27, Timur Safin <tsafin@tarantool.org> wrote:
: >
: > As a random bypasser I could not resist and not add my 5 kopecks (see
: below).
: >


: >
: Fixed.
: 
: commit 386ba8676c0ebd381d9c03b2ebf80abd986de73b (HEAD -> romanhabibov/gh-
: 4697-scalar-bug, origin/romanhabibov/gh-4697-scalar-bug)
: Author: Roman Khabibov <roman.habibov@tarantool.org>
: Date:   Mon Apr 13 05:03:54 2020 +0300
: 
:     sql: fix sorting rules for scalar
: 
:     Sort values​in the correct order for scalar type when using the
:     vdbe sorter. Boolean always precedes number if it is sorted in
:     ascending order.
: 
:     Closes #4697
: 
: diff --git a/test/sql-tap/gh-4697-scalar-bug.test.lua b/test/sql-tap/gh-
: 4697-scalar-bug.test.lua
: new file mode 100755
: index 000000000..6f600f27b
: --- /dev/null
: +++ b/test/sql-tap/gh-4697-scalar-bug.test.lua
: @@ -0,0 +1,35 @@
: +#!/usr/bin/env tarantool
: +test = require("sqltester")
: +test:plan(2)
: +
: +--
: +-- gh-4679: Make sure that boolean follow before any number within
: +-- scalar. Result with order by indexed (using index) and
: +-- non-indexed (using no index) must be the same.
: +--

Not everywhere (see the same problem above ^ in the test code)

Timur

P.S.
That was the purpose of 'g' modifier in my sed expression :)
To replace all occurrences, not only the first one.