From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org> To: tarantool-patches@freelists.org, Nikita Pettik <korablev@tarantool.org> Subject: [tarantool-patches] Re: [PATCH 2/4] Fix creation of FK constraint in case of no child's PK Date: Mon, 1 Apr 2019 16:41:53 +0300 [thread overview] Message-ID: <1d5a2af3-7412-273b-7f6a-5d296b152e41@tarantool.org> (raw) In-Reply-To: <20935e8a64d7056a0316b71a933521567705be26.1553883575.git.korablev@tarantool.org> Hi! Thanks for the patch! I've made a tiny fix and force merged it into the commit. After that the patchset LGTM. ============================================= diff --git a/test/sql/foreign-keys.result b/test/sql/foreign-keys.result index 97c3e2442..d69f93a9c 100644 --- a/test/sql/foreign-keys.result +++ b/test/sql/foreign-keys.result @@ -387,10 +387,7 @@ box.space.T4:drop() ... -- Make sure that child space can feature no PK. -- -t1 = box.schema.create_space("T1") ---- -... -box.space.T1:format({'ID'}) +t1 = box.schema.create_space("T1", {format = {'ID'}}) --- ... t2 = box.schema.create_space("T2") diff --git a/test/sql/foreign-keys.test.lua b/test/sql/foreign-keys.test.lua index 078c10c54..4ddf5e83b 100644 --- a/test/sql/foreign-keys.test.lua +++ b/test/sql/foreign-keys.test.lua @@ -176,8 +176,7 @@ box.space.T4:drop() -- Make sure that child space can feature no PK. -- -t1 = box.schema.create_space("T1") -box.space.T1:format({'ID'}) +t1 = box.schema.create_space("T1", {format = {'ID'}}) t2 = box.schema.create_space("T2") i1 = box.space.T2:create_index('I1') box.sql.execute("ALTER TABLE t1 ADD CONSTRAINT fk FOREIGN KEY (id) REFERENCES t2;")
next prev parent reply other threads:[~2019-04-01 13:41 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-03-29 18:24 [tarantool-patches] [PATCH 0/4] Fixes in SQL involving no-pk or no-format spaces Nikita Pettik 2019-03-29 18:24 ` [tarantool-patches] [PATCH 1/4] Drop foreign keys before indexes in space:drop() Nikita Pettik 2019-03-29 18:24 ` [tarantool-patches] [PATCH 2/4] Fix creation of FK constraint in case of no child's PK Nikita Pettik 2019-04-01 13:41 ` Vladislav Shpilevoy [this message] 2019-03-29 18:24 ` [tarantool-patches] [PATCH 3/4] sql: disallow creation of index on space without format Nikita Pettik 2019-03-29 18:24 ` [tarantool-patches] [PATCH 4/4] sql: disallow creation of FK referencing space without PK Nikita Pettik
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1d5a2af3-7412-273b-7f6a-5d296b152e41@tarantool.org \ --to=v.shpilevoy@tarantool.org \ --cc=korablev@tarantool.org \ --cc=tarantool-patches@freelists.org \ --subject='[tarantool-patches] Re: [PATCH 2/4] Fix creation of FK constraint in case of no child'\''s PK' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox