From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 611032988A for ; Mon, 1 Apr 2019 09:41:56 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id riDzR5A-2YQp for ; Mon, 1 Apr 2019 09:41:56 -0400 (EDT) Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 1E04C2987F for ; Mon, 1 Apr 2019 09:41:56 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH 2/4] Fix creation of FK constraint in case of no child's PK References: <20935e8a64d7056a0316b71a933521567705be26.1553883575.git.korablev@tarantool.org> From: Vladislav Shpilevoy Message-ID: <1d5a2af3-7412-273b-7f6a-5d296b152e41@tarantool.org> Date: Mon, 1 Apr 2019 16:41:53 +0300 MIME-Version: 1.0 In-Reply-To: <20935e8a64d7056a0316b71a933521567705be26.1553883575.git.korablev@tarantool.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org, Nikita Pettik Hi! Thanks for the patch! I've made a tiny fix and force merged it into the commit. After that the patchset LGTM. ============================================= diff --git a/test/sql/foreign-keys.result b/test/sql/foreign-keys.result index 97c3e2442..d69f93a9c 100644 --- a/test/sql/foreign-keys.result +++ b/test/sql/foreign-keys.result @@ -387,10 +387,7 @@ box.space.T4:drop() ... -- Make sure that child space can feature no PK. -- -t1 = box.schema.create_space("T1") ---- -... -box.space.T1:format({'ID'}) +t1 = box.schema.create_space("T1", {format = {'ID'}}) --- ... t2 = box.schema.create_space("T2") diff --git a/test/sql/foreign-keys.test.lua b/test/sql/foreign-keys.test.lua index 078c10c54..4ddf5e83b 100644 --- a/test/sql/foreign-keys.test.lua +++ b/test/sql/foreign-keys.test.lua @@ -176,8 +176,7 @@ box.space.T4:drop() -- Make sure that child space can feature no PK. -- -t1 = box.schema.create_space("T1") -box.space.T1:format({'ID'}) +t1 = box.schema.create_space("T1", {format = {'ID'}}) t2 = box.schema.create_space("T2") i1 = box.space.T2:create_index('I1') box.sql.execute("ALTER TABLE t1 ADD CONSTRAINT fk FOREIGN KEY (id) REFERENCES t2;")