Re: [Tarantool-patches] [PATCH luajit v2 1/5] ci: clean up workflow for exotic builds

[Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Thanks for the patch! LGTM

On 7/21/23 11:12, Igor Munkin wrote:
> Unfortunately, the same mistake, that was introduced in the very first
> commit f877b7691d9eae73d64c63ee3770089569915459 ("ci: introduce GitHub
> Actions") and was fixed in the main testing pipeline in scope of the
> commit 524616a35c1267cb9ca260b8456b71dde1881e22 ("ci: remove GC64 matrix
> entries for ARM64 workflows"), was made in the new CI pipeline added in
> scope of the commit 32ac0cadcba58cd69058084c88100fdcc7b7dccf ("ci: add
> ARM64 architecture to exotic testing").
>
> Specifically, CMake option LUAJIT_ENABLE_GC64 changes nothing for ARM64
> LuaJIT builds (i.e. LJ_GC64 is defined on ARM64 platforms despite the
> value of LUAJIT_ENABLE_GC64). As a result GC64 entry is removed from
> all ARM64 flavors in exotic builds testing routine.
>
> Besides, all flavor labels are sorted alphabetically.
>
> Signed-off-by: Igor Munkin <imun@tarantool.org>
> ---
>   .github/workflows/exotic-builds-testing.yml | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/.github/workflows/exotic-builds-testing.yml b/.github/workflows/exotic-builds-testing.yml
> index 318fb4dd..7c57d238 100644
> --- a/.github/workflows/exotic-builds-testing.yml
> +++ b/.github/workflows/exotic-builds-testing.yml
> @@ -34,7 +34,7 @@ jobs:
>           BUILDTYPE: [Debug, Release]
>           ARCH: [ARM64, x86_64]
>           GC64: [ON, OFF]
> -        FLAVOR: [dualnum, checkhook, nojit, gdbjit]
> +        FLAVOR: [checkhook, dualnum, gdbjit, nojit]
>           include:
>             - BUILDTYPE: Debug
>               CMAKEFLAGS: -DCMAKE_BUILD_TYPE=Debug -DLUA_USE_ASSERT=ON -DLUA_USE_APICHECK=ON
> @@ -49,6 +49,8 @@ jobs:
>             - FLAVOR: gdbjit
>               FLAVORFLAGS: -DLUAJIT_USE_GDBJIT=ON
>           exclude:
> +          - ARCH: ARM64
> +            GC64: OFF
>             # DUALNUM is default for ARM64, no need for additional testing.
>             - FLAVOR: dualnum
>               ARCH: ARM64