From: "Alexander V. Tikhonov" <avtikhon@tarantool.org> To: Kirill Yukhin <kyukhin@tarantool.org>, Alexander Turenko <alexander.turenko@tarantool.org>, Igor Munkin <imun@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: [Tarantool-patches] [PATCH v3 1/3] test: fix for OpenSuSE luajit tests build Date: Wed, 8 Jul 2020 17:39:41 +0300 [thread overview] Message-ID: <1d2eb0604408a837fa2e3feecf924b2b1b216741.1594218821.git.avtikhon@tarantool.org> (raw) In-Reply-To: <0e52466494236c1f337b36f3248494f2cdeb4c4f.1594218821.git.avtikhon@tarantool.org> Found that OpenSUSE toolchain adds '--no-undefined' linked flag leading to fails while building tests. The changes suppress this flag since dynamic libraries are loaded via Tarantool executable and use its symbols. So it is completely OK to have undefined symbols at build time. Feel free to adjust it on your own. Needed for #4562 --- Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4562-suse-pack-full-ci Issue: https://github.com/tarantool/tarantool/issues/4562 test/CMakeLists.txt | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/test/CMakeLists.txt b/test/CMakeLists.txt index 697d1b21d..93de3d68b 100644 --- a/test/CMakeLists.txt +++ b/test/CMakeLists.txt @@ -23,6 +23,11 @@ endfunction() add_compile_flags("C;CXX" "-Wno-unused-parameter") +# The dynamic libraries will be loaded from tarantool executable +# and will use symbols from it. So it is completely okay to have +# unresolved symbols at build time. +string(REPLACE "-Wl,--no-undefined" "" CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS}") + if(POLICY CMP0037) if(CMAKE_VERSION VERSION_LESS 3.11) # cmake below 3.11 reserves name test. Use old policy. -- 2.17.1
next parent reply other threads:[~2020-07-08 14:39 UTC|newest] Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <0e52466494236c1f337b36f3248494f2cdeb4c4f.1594218821.git.avtikhon@tarantool.org> 2020-07-08 14:39 ` Alexander V. Tikhonov [this message] 2020-08-14 2:55 ` Alexander Turenko 2020-07-08 14:39 ` [Tarantool-patches] [PATCH v3 3/3] gitlab-ci: add openSuSE packages build jobs Alexander V. Tikhonov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1d2eb0604408a837fa2e3feecf924b2b1b216741.1594218821.git.avtikhon@tarantool.org \ --to=avtikhon@tarantool.org \ --cc=alexander.turenko@tarantool.org \ --cc=imun@tarantool.org \ --cc=kyukhin@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v3 1/3] test: fix for OpenSuSE luajit tests build' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox