From: Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Maxim Kokryashkin <m.kokryashkin@tarantool.org>, Sergey Bronnikov <estetus@gmail.com> Cc: max.kokryashkin@gmail.com, tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH 4/4][v2] ci: enable checkpatch Date: Thu, 20 Jul 2023 21:14:32 +0300 [thread overview] Message-ID: <1cc3d336-782c-64ea-95fe-388360d4ea6a@tarantool.org> (raw) In-Reply-To: <1689619710.740225619@f193.i.mail.ru> [-- Attachment #1: Type: text/plain, Size: 1941 bytes --] Hi, Max! thanks for your review! On 7/17/23 21:48, Maxim Kokryashkin via Tarantool-patches wrote: > Hi, Sergey! > Thanks for the patch! > Please consider my comments below. > > From: Sergey Bronnikov <sergeyb@tarantool.org > </compose?To=sergeyb@tarantool.org>> > > Patch enables running checkpatch [1] for checking patch on a > pre-commit > > The pre-commit stage makes no sense when we are talking about CI — the > commit has already occurred. That’s just a conventional workflow > configuration. > In my mind "pre-commit" means commit to a target branch, in our case it is a "tarantool/master". > > Having that in mind, along with some grammar related issues. I suggest > rephrasing it like: > | Patch adds a CI workflow with the checkpatch[1] run. > Updated. > > stage. > > 1. https://github.com/tarantool/checkpatch > --- > .github/actions/checkpatch/action.yml | 11 +++++++++++ > .github/workflows/lint.yml | 20 ++++++++++++++++++++ > 2 files changed, 31 insertions(+) > create mode 100644 .github/actions/checkpatch/action.yml > > diff --git a/.github/actions/checkpatch/action.yml > b/.github/actions/checkpatch/action.yml > new file mode 100644 > index 00000000..2336fb15 > --- /dev/null > +++ b/.github/actions/checkpatch/action.yml > @@ -0,0 +1,11 @@ > +name: Checkpatch > +description: Check patches against LuaJIT development guidelines > > I think it’s better to change the action name to `Setup checkpatch`, > since the actual run is not performed here. > The description should be updated correspondingly. Also, AFAIK, there > is no such thing as `LuaJIT guidelines`, so maybe it’s better to > change it > to `Tarantool guidelines` if you want to keep that part. > Updated. <snipped> [-- Attachment #2: Type: text/html, Size: 4925 bytes --]
next prev parent reply other threads:[~2023-07-20 18:14 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-07-17 13:34 [Tarantool-patches] [PATCH 0/4][v2] Fix typos and " Sergey Bronnikov via Tarantool-patches 2023-07-17 13:34 ` [Tarantool-patches] [PATCH 1/4][v2] ci: fix a step name Sergey Bronnikov via Tarantool-patches 2023-07-17 15:43 ` Maxim Kokryashkin via Tarantool-patches 2023-07-17 13:34 ` [Tarantool-patches] [PATCH 2/4][v2] codehealth: fix typos Sergey Bronnikov via Tarantool-patches 2023-07-17 15:48 ` Maxim Kokryashkin via Tarantool-patches 2023-07-17 13:34 ` [Tarantool-patches] [PATCH 3/4][v2] cmake: introduce 'check' and 'LuaJIT-checkpatch' targets Sergey Bronnikov via Tarantool-patches 2023-07-17 16:10 ` Maxim Kokryashkin via Tarantool-patches 2023-07-20 18:07 ` Sergey Bronnikov via Tarantool-patches 2023-07-20 21:13 ` Maxim Kokryashkin via Tarantool-patches 2023-07-17 13:34 ` [Tarantool-patches] [PATCH 4/4][v2] ci: enable checkpatch Sergey Bronnikov via Tarantool-patches 2023-07-17 18:48 ` Maxim Kokryashkin via Tarantool-patches 2023-07-20 18:14 ` Sergey Bronnikov via Tarantool-patches [this message] 2023-07-20 21:14 ` Maxim Kokryashkin via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1cc3d336-782c-64ea-95fe-388360d4ea6a@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=estetus@gmail.com \ --cc=m.kokryashkin@tarantool.org \ --cc=max.kokryashkin@gmail.com \ --cc=sergeyb@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH 4/4][v2] ci: enable checkpatch' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox