From: "Timur Safin" <tsafin@tarantool.org>
To: 'Mergen Imeev' <imeevma@tarantool.org>,
'Roman Khabibov' <roman.habibov@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] sql: fix number and boolean sorting rules
Date: Fri, 17 Apr 2020 10:27:20 +0300 [thread overview]
Message-ID: <1c1301d61489$a1af1790$e50d46b0$@tarantool.org> (raw)
In-Reply-To: <20200417063512.GA10928@tarantool.org>
As a random bypasser I could not resist and not add my 5 kopecks (see below).
: -----Original Message-----
: From: Mergen Imeev <imeevma@tarantool.org>
:
: Hi! Thank you for the fixes. I think that the your
: commit-message and comments sounds quite strange, but I am
: not sure that I am qualified enough to say that for sure.
: Please, send this patch to NIkita. Other than that, LGTM.
:
: > commit 8a2133d84b88a050181d858d6109abf3635a121b (HEAD ->
: romanhabibov/gh-4697-scalar-bug, origin/romanhabibov/gh-4697-scalar-bug)
: > Author: Roman Khabibov <roman.habibov@tarantool.org>
: > Date: Mon Apr 13 05:03:54 2020 +0300
: >
: > sql: fix number and boolean SCALAR sorting rules
: >
: > Make comparison SCALAR rules in the sql sorter correct for number
: > and boolean. Boolean should always follow before any number.
: >
: > Closes #4697
: >
Agreed with Mergen that message is confusing, I'd suggest to do this simple replacement to make it clearer
s/follow before/precede/g
Regards,
Timur
next prev parent reply other threads:[~2020-04-17 7:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-13 4:11 Roman Khabibov
2020-04-15 19:41 ` Mergen Imeev
2020-04-16 0:34 ` Roman Khabibov
2020-04-16 8:17 ` Mergen Imeev
2020-04-17 0:48 ` Roman Khabibov
2020-04-17 6:35 ` Mergen Imeev
2020-04-17 7:27 ` Timur Safin [this message]
2020-04-17 11:25 ` Roman Khabibov
2020-04-17 11:51 ` Timur Safin
2020-04-18 2:46 ` Roman Khabibov
2020-04-18 9:18 ` Timur Safin
2020-04-20 0:12 ` Roman Khabibov
2020-04-20 1:05 ` Nikita Pettik
2020-04-20 20:28 ` Roman Khabibov
2020-04-20 23:57 ` Nikita Pettik
2020-04-24 13:03 ` Roman Khabibov
2020-04-27 1:34 ` Nikita Pettik
2020-04-27 15:31 ` Nikita Pettik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='1c1301d61489$a1af1790$e50d46b0$@tarantool.org' \
--to=tsafin@tarantool.org \
--cc=imeevma@tarantool.org \
--cc=roman.habibov@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] sql: fix number and boolean sorting rules' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox