Re: [Tarantool-patches] [PATCH v7 0/2] fiber: Handle stack madvise/mprotect errors

[Vladislav Shpilevoy <v.shpilevoy@tarantool.org>]

Thanks for the fixes!

Please, put branch and issue link here next time.
It is really hard to find that branch just by commit
title, or by searching for older versions of the
branch in email history. Especially taking into
account that there are 7 versions of mprotect branches.

Btw, you can force push into one branch, it is ok, and
is even more convenient. At least from reviewer's point
of view.

On 13/02/2020 21:56, Cyrill Gorcunov wrote:
> Changes in v7:
>  - address Vlad's comments
>  - add test for slab leak when mprotect fails on exit path
> 
> Still the beautifying of errinj is send as a separate patch
> so diff is pretty big for now.
> 
> Cyrill Gorcunov (2):
>   fiber: set diagnostics at madvise/mprotect failure
>   fiber: leak slab if unable to bring prots back
> 
>  src/lib/core/errinj.h        |   2 +
>  src/lib/core/fiber.c         |  93 +++++++++++++++++++-----
>  test/box/errinj.result       | 136 ++++++++++++++++++-----------------
>  test/unit/CMakeLists.txt     |   4 ++
>  test/unit/fiber_stack.c      | 102 ++++++++++++++++++++++++++
>  test/unit/fiber_stack.result |  10 +++
>  test/unit/suite.ini          |   2 +-
>  7 files changed, 264 insertions(+), 85 deletions(-)
>  create mode 100644 test/unit/fiber_stack.c
>  create mode 100644 test/unit/fiber_stack.result
>