From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Nikita Pettik <korablev@tarantool.org>,
tarantool-patches@freelists.org,
Kirill Yukhin <kyukhin@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH 0/2] Add collation to built-in funcs and fix HAVING clause with aggregate
Date: Thu, 7 Mar 2019 17:40:22 +0300 [thread overview]
Message-ID: <1b0173d6-42cd-bfc4-4b27-53ba08d3ebbd@tarantool.org> (raw)
In-Reply-To: <cover.1550768589.git.korablev@tarantool.org>
LGTM.
On 21/02/2019 21:01, Nikita Pettik wrote:
> Issue #3932 consists of two independent bugs. Current patch-set
> provides fixes for both of them.
>
> Branch: https://github.com/tarantool/tarantool/tree/np/gh-3932-function-collation
> Issue: https://github.com/tarantool/tarantool/issues/3932
>
> Nikita Pettik (2):
> sql: derive collation for built-in functions
> sql: fix code generation for aggregate in HAVING clause
>
> src/box/sql/analyze.c | 6 +++---
> src/box/sql/expr.c | 23 +++++++++++++++++++++++
> src/box/sql/func.c | 22 +++++++++++-----------
> src/box/sql/resolve.c | 10 +++++++---
> src/box/sql/sqlInt.h | 31 +++++++++++++++++++++++--------
> test/sql-tap/select5.test.lua | 25 ++++++++++++++++++++++++-
> test/sql/collation.result | 28 ++++++++++++++++++++++++++++
> test/sql/collation.test.lua | 11 +++++++++++
> 8 files changed, 130 insertions(+), 26 deletions(-)
>
> --
> 2.15.1
>
next prev parent reply other threads:[~2019-03-07 14:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-21 18:01 [tarantool-patches] " Nikita Pettik
2019-02-21 18:01 ` [tarantool-patches] [PATCH 1/2] sql: derive collation for built-in functions Nikita Pettik
2019-02-25 12:58 ` [tarantool-patches] " Vladislav Shpilevoy
2019-02-25 18:32 ` n.pettik
2019-03-07 14:40 ` Vladislav Shpilevoy
2019-03-11 8:04 ` Konstantin Osipov
2019-02-21 18:01 ` [tarantool-patches] [PATCH 2/2] sql: fix code generation for aggregate in HAVING clause Nikita Pettik
2019-02-25 12:58 ` [tarantool-patches] " Vladislav Shpilevoy
2019-02-25 18:33 ` n.pettik
2019-03-04 12:14 ` n.pettik
2019-03-04 12:52 ` Vladislav Shpilevoy
2019-03-07 14:40 ` Vladislav Shpilevoy [this message]
2019-03-11 15:49 ` [tarantool-patches] Re: [PATCH 0/2] Add collation to built-in funcs and fix HAVING clause with aggregate Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b0173d6-42cd-bfc4-4b27-53ba08d3ebbd@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=korablev@tarantool.org \
--cc=kyukhin@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH 0/2] Add collation to built-in funcs and fix HAVING clause with aggregate' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox