Re: [Tarantool-patches] [PATCH 13/20] net.box: rewrite send_and_recv_{iproto, console} in C

[Vladislav Shpilevoy via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Hi! Thanks for the fixes!

> diff --git a/src/box/lua/net_box.c b/src/box/lua/net_box.c
> index 19289e750..6d6d09aca 100644
> --- a/src/box/lua/net_box.c
> +++ b/src/box/lua/net_box.c

<...>

> +
> +/**
> + * Sends and receives data over an iproto connection.
> + * Takes socket fd, send_buf (ibuf), recv_buf (ibuf), timeout.
> + * On success returns header (table), body_rpos (char *), body_end (char *).
> + * On error returns nil, error.
> + */
> +static int
> +netbox_send_and_recv_iproto(lua_State *L)
> +{
> +	int fd = lua_tointeger(L, 1);
> +	struct ibuf *send_buf = (struct ibuf *)lua_topointer(L, 2);
> +	struct ibuf *recv_buf = (struct ibuf *)lua_topointer(L, 3);
> +	double timeout = (!lua_isnoneornil(L, 4) ?
> +			  lua_tonumber(L, 4) : TIMEOUT_INFINITY);

Timeout is never passed to this function. It is always TIMEOUT_INFINITY.
The same for netbox_send_and_recv_console.