From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: tarantool-patches@freelists.org,
AKhatskevich <avkhatskevich@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH 1/2] Preserve route_map on router.cfg
Date: Thu, 21 Jun 2018 15:54:22 +0300 [thread overview]
Message-ID: <1a1b796e-0253-0ad4-fb47-7f8ae6aa28b0@tarantool.org> (raw)
In-Reply-To: <344d2c601d489836268d55e0f9207f2a6a577f81.1529066485.git.avkhatskevich@tarantool.org>
Thanks for the patch! See 2 comments below.
On 15/06/2018 15:47, AKhatskevich wrote:
> Routes in `M.route_map` can be preserved during reconfigure process.
> This is necessary to prevent a dramatic performance degradation just
> after reconfugure and reload.
1. Problems with alignment.
2. Typo.
>
> Closes #117
> ---
> test/router/router.result | 42 ++++++++++++++++++++++++++++++++++++++++++
> test/router/router.test.lua | 24 ++++++++++++++++++++++++
> vshard/router/init.lua | 7 +++++--
> 3 files changed, 71 insertions(+), 2 deletions(-)
>
next prev parent reply other threads:[~2018-06-21 12:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-15 12:47 [tarantool-patches] [PATCH 0/2][vshard] preserve route map AKhatskevich
2018-06-15 12:47 ` [tarantool-patches] [PATCH 1/2] Preserve route_map on router.cfg AKhatskevich
2018-06-21 12:54 ` Vladislav Shpilevoy [this message]
2018-06-25 12:48 ` [tarantool-patches] " Alex Khatskevich
2018-06-15 12:47 ` [tarantool-patches] [PATCH 2/2] Fix discovery/reconfigure race AKhatskevich
2018-06-21 12:54 ` [tarantool-patches] " Vladislav Shpilevoy
2018-06-25 12:48 ` Alex Khatskevich
2018-06-26 11:11 ` Vladislav Shpilevoy
2018-06-26 14:03 ` Alex Khatskevich
2018-06-27 11:45 ` Vladislav Shpilevoy
2018-06-27 19:50 ` Alex Khatskevich
2018-06-28 19:41 ` Vladislav Shpilevoy
2018-06-21 12:54 ` [tarantool-patches] Re: [PATCH 0/2][vshard] preserve route map Vladislav Shpilevoy
2018-06-25 11:52 ` Alex Khatskevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a1b796e-0253-0ad4-fb47-7f8ae6aa28b0@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=avkhatskevich@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH 1/2] Preserve route_map on router.cfg' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox