From: Serge Petrenko <sergepetrenko@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] vclock: refactor vclock map to use type uint32_t
Date: Tue, 10 Mar 2020 14:23:51 +0300 [thread overview]
Message-ID: <19BC751F-D18D-4942-A67F-EECE82FCE78D@tarantool.org> (raw)
In-Reply-To: <2e299aec-23c8-400d-8daf-3f7f8d015c48@tarantool.org>
> 9 марта 2020 г., в 01:16, Vladislav Shpilevoy <v.shpilevoy@tarantool.org> написал(а):
>
> Hi! Thanks for the fixes!
>
> I think you can just merge the second commit into the
> first one. If you don't want, then prepend that commit's
> title with a subsystem name.
>
> xrow: use bit_count_u32() for replica_id filter
>
> instead of
>
> use bit_count_u32() for replica_id filter
>
Hi! Changed the commit title.
`use bit_count_u32() for replica_id filter` -> `xrow: use bit_count_u32() for replica_id filter`
> After that LGTM.
--
Serge Petrenko
sergepetrenko@tarantool.org
next prev parent reply other threads:[~2020-03-10 11:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-05 11:36 Serge Petrenko
2020-03-05 20:46 ` Vladislav Shpilevoy
2020-03-06 8:58 ` Serge Petrenko
2020-03-08 22:16 ` Vladislav Shpilevoy
2020-03-10 11:23 ` Serge Petrenko [this message]
2020-03-16 20:31 ` Konstantin Osipov
2020-03-19 14:36 ` Serge Petrenko
2020-03-19 14:47 ` Konstantin Osipov
2020-03-20 11:15 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19BC751F-D18D-4942-A67F-EECE82FCE78D@tarantool.org \
--to=sergepetrenko@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] vclock: refactor vclock map to use type uint32_t' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox