From: "n.pettik" <korablev@tarantool.org>
To: tarantool-patches@freelists.org
Cc: Imeev Mergen <imeevma@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v4 1/6] sql: remove unused macros from pragma.c and pragma.h
Date: Sun, 20 Jan 2019 03:16:46 +0300 [thread overview]
Message-ID: <19958464-07A6-486E-9717-AE69E3BD4B43@tarantool.org> (raw)
In-Reply-To: <28ff08bf9df3a3948fdc399f4801f01d170c52a5.1547899933.git.imeevma@gmail.com>
>
> commit 28ff08bf9df3a3948fdc399f4801f01d170c52a5
> Author: Mergen Imeev <imeevma@gmail.com>
> Date: Wed Dec 12 21:58:54 2018 +0300
>
> sql: remove unused macros from pragma.c and pragma.h
>
> Some macros in pragma.c and pragma.h are obsolete because the
> values they are checking are no longer used. Let's remove them.
In fact they are used, but their usage makes no sense.
Then LGTM.
next prev parent reply other threads:[~2019-01-20 0:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-19 12:37 [tarantool-patches] [PATCH v4 0/6] sql: set column types for EXPLAIN and PRAGMA imeevma
2019-01-19 12:37 ` [tarantool-patches] [PATCH v4 1/6] sql: remove unused macros from pragma.c and pragma.h imeevma
2019-01-20 0:16 ` n.pettik [this message]
2019-01-24 14:52 ` [tarantool-patches] " Imeev Mergen
2019-01-19 12:37 ` [tarantool-patches] [PATCH v4 2/6] sql: fix "PRAGMA parser_trace" result imeevma
2019-01-19 12:37 ` [tarantool-patches] [PATCH v4 3/6] sql: Show currently set sql_default_engine imeevma
2019-01-19 12:37 ` [tarantool-patches] [PATCH v4 4/6] sql: fix "PRAGMA case_sensitive_like" result imeevma
2019-01-19 12:37 ` [tarantool-patches] [PATCH v4 5/6] sql: 'PRAGMA' result in YAML format imeevma
2019-01-20 0:19 ` [tarantool-patches] " n.pettik
2019-01-24 14:53 ` Imeev Mergen
2019-01-19 12:37 ` [tarantool-patches] [PATCH v4 6/6] sql: set column types for EXPLAIN and PRAGMA imeevma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19958464-07A6-486E-9717-AE69E3BD4B43@tarantool.org \
--to=korablev@tarantool.org \
--cc=imeevma@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH v4 1/6] sql: remove unused macros from pragma.c and pragma.h' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox