From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Aleksandr Lyapunov <alyapunov@tarantool.org>,
tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 11/16] tx: introduce conflict tracker
Date: Wed, 15 Jul 2020 01:51:18 +0200 [thread overview]
Message-ID: <198d4c8b-0e6b-9cd0-1d80-8d40f6c68081@tarantool.org> (raw)
In-Reply-To: <1594221263-6228-12-git-send-email-alyapunov@tarantool.org>
Thanks for the patch!
See 1 comment below.
On 08.07.2020 17:14, Aleksandr Lyapunov wrote:
> ---
> src/box/txn.c | 98 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> src/box/txn.h | 5 +++
> 2 files changed, 103 insertions(+)
>
> diff --git a/src/box/txn.c b/src/box/txn.c
> index 2bd44a3..b9f1737 100644
> --- a/src/box/txn.c
> +++ b/src/box/txn.c
> @@ -998,3 +1053,46 @@ void
> tx_manager_free()
> {
> }
> +
> +int
> +txm_cause_conflict(struct txn *wreaker, struct txn *victim)
> +{
> + struct tx_conflict_tracker *tracker = NULL;
> + struct rlist *r1 = wreaker->conflict_list.next;
> + struct rlist *r2 = wreaker->conflicted_by_list.next;
> + while (r1 != &wreaker->conflict_list &&
> + r2 != &wreaker->conflicted_by_list) {
> + tracker = rlist_entry(r1, struct tx_conflict_tracker,
> + in_conflict_list);
> + if (tracker->wreaker == wreaker && tracker->victim == victim)
> + break;
> + tracker = rlist_entry(r2, struct tx_conflict_tracker,
> + in_conflicted_by_list);
> + if (tracker->wreaker == wreaker && tracker->victim == victim)
> + break;
> + tracker = NULL;
> + r1 = r1->next;
> + r2 = r2->next;
> + }
> + if (tracker != NULL) {
> + /* Move to the beginning of a list
> + * for a case of subsequent lookups */
> + rlist_del(&tracker->in_conflict_list);
> + rlist_del(&tracker->in_conflicted_by_list);
> + } else {
> + size_t size;
> + tracker = region_alloc_object(&victim->region,
> + struct tx_conflict_tracker,
> + &size);
> + if (tracker == NULL) {
> + diag_set(OutOfMemory, size, "tx region",
> + "conflict_tracker");
> + return -1;
> + }
> + }
> + tracker->wreaker = wreaker;
> + tracker->victim = victim;
Why don't you save anything into the victim? How will it be
removed from the lists if it will commit earlier than 'wreaker'?
next prev parent reply other threads:[~2020-07-14 23:51 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-08 15:14 [Tarantool-patches] [PATCH v2 00/16] Transaction engine for memtx engine Aleksandr Lyapunov
2020-07-08 15:14 ` [Tarantool-patches] [PATCH 01/16] Update license file (2020) Aleksandr Lyapunov
2020-07-08 15:14 ` [Tarantool-patches] [PATCH 02/16] Check data_offset overflow in struct tuple Aleksandr Lyapunov
2020-07-12 17:15 ` Vladislav Shpilevoy
2020-07-14 17:09 ` Aleksandr Lyapunov
2020-07-14 22:48 ` Vladislav Shpilevoy
2020-07-08 15:14 ` [Tarantool-patches] [PATCH 03/16] tx: introduce dirty tuples Aleksandr Lyapunov
2020-07-12 17:15 ` Vladislav Shpilevoy
2020-07-12 22:24 ` Nikita Pettik
2020-07-08 15:14 ` [Tarantool-patches] [PATCH 04/16] vinyl: rename tx_manager -> vy_tx_manager Aleksandr Lyapunov
2020-07-12 17:14 ` Vladislav Shpilevoy
2020-07-08 15:14 ` [Tarantool-patches] [PATCH 05/16] tx: save txn in txn_stmt Aleksandr Lyapunov
2020-07-12 17:15 ` Vladislav Shpilevoy
2020-07-08 15:14 ` [Tarantool-patches] [PATCH 06/16] tx: add TX status Aleksandr Lyapunov
2020-07-12 17:15 ` Vladislav Shpilevoy
2020-07-08 15:14 ` [Tarantool-patches] [PATCH 07/16] tx: save preserve old tuple flag in txn_stmt Aleksandr Lyapunov
2020-07-12 17:14 ` Vladislav Shpilevoy
2020-07-14 23:46 ` Vladislav Shpilevoy
2020-07-15 7:53 ` Aleksandr Lyapunov
2020-07-08 15:14 ` [Tarantool-patches] [PATCH 08/16] tx: introduce tx manager Aleksandr Lyapunov
2020-07-08 15:14 ` [Tarantool-patches] [PATCH 09/16] tx: introduce prepare sequence number Aleksandr Lyapunov
2020-07-08 15:14 ` [Tarantool-patches] [PATCH 10/16] tx: introduce txn_stmt_destroy Aleksandr Lyapunov
2020-07-12 17:15 ` Vladislav Shpilevoy
2020-07-08 15:14 ` [Tarantool-patches] [PATCH 11/16] tx: introduce conflict tracker Aleksandr Lyapunov
2020-07-12 17:15 ` Vladislav Shpilevoy
2020-07-14 23:51 ` Vladislav Shpilevoy [this message]
2020-07-15 7:57 ` Aleksandr Lyapunov
2020-07-08 15:14 ` [Tarantool-patches] [PATCH 12/16] introduce tuple smart pointers Aleksandr Lyapunov
2020-07-12 17:16 ` Vladislav Shpilevoy
2020-07-08 15:14 ` [Tarantool-patches] [PATCH 13/16] tx: introduce txm_story Aleksandr Lyapunov
2020-07-12 17:14 ` Vladislav Shpilevoy
2020-07-14 23:46 ` Vladislav Shpilevoy
2020-07-15 8:11 ` Aleksandr Lyapunov
2020-07-15 22:02 ` Vladislav Shpilevoy
2020-07-08 15:14 ` [Tarantool-patches] [PATCH 14/16] tx: indexes Aleksandr Lyapunov
2020-07-14 23:50 ` Vladislav Shpilevoy
2020-07-15 10:02 ` Aleksandr Lyapunov
2020-07-15 22:08 ` Vladislav Shpilevoy
2020-07-15 10:19 ` Aleksandr Lyapunov
2020-07-08 15:14 ` [Tarantool-patches] [PATCH 15/16] tx: introduce point conflict tracker Aleksandr Lyapunov
2020-07-08 15:14 ` [Tarantool-patches] [PATCH 16/16] tx: use new tx manager in memtx Aleksandr Lyapunov
2020-07-14 23:45 ` Vladislav Shpilevoy
2020-07-15 10:32 ` Aleksandr Lyapunov
2020-07-15 22:09 ` Vladislav Shpilevoy
2020-07-12 17:19 ` [Tarantool-patches] [PATCH v2 00/16] Transaction engine for memtx engine Vladislav Shpilevoy
2020-07-14 23:47 ` Vladislav Shpilevoy
2020-07-15 12:25 ` Aleksandr Lyapunov
2020-07-15 22:10 ` Vladislav Shpilevoy
2020-07-16 4:48 ` Aleksandr Lyapunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=198d4c8b-0e6b-9cd0-1d80-8d40f6c68081@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=alyapunov@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 11/16] tx: introduce conflict tracker' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox