From: Oleg Babin <olegrok@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>,
tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH vshard 7/7] router: introduce discovery mode 'once'
Date: Mon, 4 May 2020 17:27:43 +0300 [thread overview]
Message-ID: <1908eb31-0d6a-829b-59e3-4274e02beadc@tarantool.org> (raw)
In-Reply-To: <859f127f-742d-f1ca-43c4-e7badbd7d6ff@tarantool.org>
Got it. Thanks for your answer. LGTM.
On 02/05/2020 23:12, Vladislav Shpilevoy wrote:
> Thanks for the review!
>
>>> @@ -342,6 +342,13 @@ discovery_f = function(router)
>>> unknown_bucket_count =
>>> router.total_bucket_count - router.known_bucket_count
>>> if unknown_bucket_count == 0 then
>>> + if router.discovery_mode == 'once' then
>>> + log.info("Discovery mode is 'once', and all is "..
>>> + "discovered - shut down the discovery process")
>>> + router.discovery_fiber = nil
>>> + lfiber.self():cancel()
>>> + return
>>> + end
>>
>> I'm not sure that self.cancel is a good approach. I think simple "return" should be enough.
>
> The discovery fiber is restarted if it returns or throws. The only
> way to stop it is to cancel. See reloadable_fiber_main_loop() in
> vshard/vshard/util.lua.
>
next prev parent reply other threads:[~2020-05-04 14:27 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-01 0:16 [Tarantool-patches] [PATCH vshard 0/7] Router extended discovery Vladislav Shpilevoy
2020-05-01 0:16 ` [Tarantool-patches] [PATCH vshard 1/7] test: print errors in a portable way Vladislav Shpilevoy
2020-05-01 16:58 ` Oleg Babin
2020-05-02 20:08 ` Vladislav Shpilevoy
2020-05-04 14:26 ` Oleg Babin
2020-05-01 0:16 ` [Tarantool-patches] [PATCH vshard 2/7] router: introduce discovery_mode Vladislav Shpilevoy
2020-05-01 16:59 ` Oleg Babin
2020-05-01 0:16 ` [Tarantool-patches] [PATCH vshard 3/7] test: disable router discovery for some tests Vladislav Shpilevoy
2020-05-01 17:00 ` Oleg Babin
2020-05-02 20:09 ` Vladislav Shpilevoy
2020-05-04 14:26 ` Oleg Babin
2020-05-01 0:16 ` [Tarantool-patches] [PATCH vshard 4/7] test: clear route map, respecting statistics Vladislav Shpilevoy
2020-05-01 17:00 ` Oleg Babin
2020-05-01 0:16 ` [Tarantool-patches] [PATCH vshard 5/7] router: keep known bucket count stat up to date Vladislav Shpilevoy
2020-05-01 17:01 ` Oleg Babin
2020-05-01 0:16 ` [Tarantool-patches] [PATCH vshard 6/7] router: make discovery smoother in a big cluster Vladislav Shpilevoy
2020-05-01 17:01 ` Oleg Babin
2020-05-02 20:12 ` Vladislav Shpilevoy
2020-05-04 14:26 ` Oleg Babin
2020-05-04 21:09 ` Vladislav Shpilevoy
2020-05-06 8:27 ` Oleg Babin
2020-05-07 22:45 ` Konstantin Osipov
2020-05-08 19:56 ` Vladislav Shpilevoy
2020-05-09 7:37 ` Konstantin Osipov
2020-05-01 0:16 ` [Tarantool-patches] [PATCH vshard 7/7] router: introduce discovery mode 'once' Vladislav Shpilevoy
2020-05-01 17:02 ` Oleg Babin
2020-05-02 20:12 ` Vladislav Shpilevoy
2020-05-04 14:27 ` Oleg Babin [this message]
2020-05-06 20:54 ` [Tarantool-patches] [PATCH vshard 0/7] Router extended discovery Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1908eb31-0d6a-829b-59e3-4274e02beadc@tarantool.org \
--to=olegrok@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH vshard 7/7] router: introduce discovery mode '\''once'\''' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox