Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Serge Petrenko <sergepetrenko@tarantool.org>
Cc: tml <tarantool-patches@dev.tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 4/4] box: introduce indices by UUID
Date: Fri, 10 Apr 2020 18:56:41 +0200	[thread overview]
Message-ID: <18339504-b1d2-2856-a9b0-605f4f2f454f@tarantool.org> (raw)
In-Reply-To: <7FF9C776-045A-4ADF-B44B-0CFB7FD746F9@tarantool.org>

>>> +}
>>> +
>>> +static inline int
>>> +mp_compare_uuid(const char *field_a, const char *field_b)
>>> +{
>>> +	return mp_compare_uuid_with_type(field_a, mp_typeof(*field_a),
>>> +					 field_b, mp_typeof(*field_b));
>>> +}
>>> @@ -1578,6 +1642,21 @@ hint_decimal(decimal_t *dec)
>>> 	return hint_create(MP_CLASS_NUMBER, val);
>>> }
>>>
>>> +static inline hint_t
>>> +hint_uuid(struct tt_uuid *uuid)
>>> +{
>>> +	/* Simply take the first part of the UUID as hint. */
>>
>> 5. Why only first?
> 
> I meant, take the ‘high’ part of the UUID. The one which’s compared first.

The current hint is good. I forgot hints should be ordered.

  reply	other threads:[~2020-04-10 16:56 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-03 23:02 [Tarantool-patches] [PATCH 0/4] introduce indices over UUID Serge Petrenko
2020-04-03 23:02 ` [Tarantool-patches] [PATCH 1/4] decimal: fix comment typo Serge Petrenko
2020-04-05 21:22   ` Vladislav Shpilevoy
2020-04-03 23:02 ` [Tarantool-patches] [PATCH 2/4] uuid: expose additional from_string constructors Serge Petrenko
2020-04-05 21:22   ` Vladislav Shpilevoy
2020-04-09 23:46     ` Serge Petrenko
2020-04-10 16:56       ` Vladislav Shpilevoy
2020-04-11 13:35         ` Serge Petrenko
2020-04-03 23:02 ` [Tarantool-patches] [PATCH 3/4] box: add MsgPack encoding/decoding for UUID Serge Petrenko
2020-04-05 21:26   ` Vladislav Shpilevoy
2020-04-09 23:46     ` Serge Petrenko
2020-04-03 23:02 ` [Tarantool-patches] [PATCH 4/4] box: introduce indices by UUID Serge Petrenko
2020-04-05 21:29   ` Vladislav Shpilevoy
2020-04-09 23:46     ` Serge Petrenko
2020-04-10 16:56       ` Vladislav Shpilevoy [this message]
2020-04-05 21:21 ` [Tarantool-patches] [PATCH 0/4] introduce indices over UUID Vladislav Shpilevoy
2020-04-09 23:46   ` Serge Petrenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18339504-b1d2-2856-a9b0-605f4f2f454f@tarantool.org \
    --to=v.shpilevoy@tarantool.org \
    --cc=sergepetrenko@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH 4/4] box: introduce indices by UUID' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox