From: "Alexander V. Tikhonov" <avtikhon@tarantool.org> To: Igor Munkin <imun@tarantool.org>, Kirill Yukhin <kyukhin@tarantool.org> Cc: tarantool-patches@dev.tarantool.org, Alexander Turenko <alexander.turenko@tarantool.org> Subject: [Tarantool-patches] [PATCH v1] build: make curl symbols global Date: Thu, 8 Oct 2020 11:05:03 +0300 [thread overview] Message-ID: <18048f3308fd4e1372b0cda3e82e8a1c2d86ca71.1602143974.git.avtikhon@tarantool.org> (raw) In-Reply-To: <4fc536691abbbbb9f3439bb60bef7a551663a5b5.1602143974.git.avtikhon@tarantool.org> Building using cmake got issue in testing: [043] box-tap/gh-5223-curl-exports.test.lua [ fail ] [043] Test failed! Output from reject file box-tap/gh-5223-curl-exports.reject: [043] [043] Last 15 lines of Tarantool Log file [Instance "app_server"][/build/usr/src/debug/tarantool-2.6.0.54/test/var/043_box-tap/gh-5223-curl-exports.test.lua.tarantool.log]: [043] LuajitError: ...tool-2.6.0.54/test/box-tap/gh-5223-curl-exports.test.lua:57: tarantool: undefined symbol: curl_version_info It happened because curl used visibility hiding mode for its symbols and the test could not use it. To fix it symbols hiding disabled for gcc and clang. Closes #5268 --- Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4874-out-of-source-build-full-ci Issue: https://github.com/tarantool/tarantool/issues/5268 third_party/curl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/third_party/curl b/third_party/curl index 5a1fc8d33..ac15de38d 160000 --- a/third_party/curl +++ b/third_party/curl @@ -1 +1 @@ -Subproject commit 5a1fc8d33808d7b22f57bdf9403cda7ff07b0670 +Subproject commit ac15de38d981f22affbc4d275a3b874e0eee57d6 -- 2.25.1
next prev parent reply other threads:[~2020-10-08 8:05 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-10-08 8:03 [Tarantool-patches] [PATCH v3] build: enable cmake in curl build Alexander V. Tikhonov 2020-10-08 8:05 ` Alexander V. Tikhonov [this message] 2020-10-13 11:47 ` [Tarantool-patches] [PATCH v1] build: make curl symbols global Igor Munkin 2020-10-08 8:09 ` [Tarantool-patches] [PATCH v1] gitlab-ci: add out-of-source build Alexander V. Tikhonov 2020-10-13 20:39 ` Igor Munkin 2020-10-14 9:07 ` Alexander V. Tikhonov 2020-10-12 18:52 ` [Tarantool-patches] [PATCH v3] build: enable cmake in curl build Igor Munkin 2020-10-13 10:20 ` Igor Munkin 2020-10-14 9:08 ` Alexander V. Tikhonov 2020-10-14 9:12 ` Alexander V. Tikhonov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=18048f3308fd4e1372b0cda3e82e8a1c2d86ca71.1602143974.git.avtikhon@tarantool.org \ --to=avtikhon@tarantool.org \ --cc=alexander.turenko@tarantool.org \ --cc=imun@tarantool.org \ --cc=kyukhin@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v1] build: make curl symbols global' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox