From: Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Maxim Kokryashkin <max.kokryashkin@gmail.com>, tarantool-patches@dev.tarantool.org, skaplun@tarantool.org Subject: Re: [Tarantool-patches] [PATCH luajit 1/2] memprof: refactor symbol resolution Date: Tue, 5 Sep 2023 14:47:15 +0300 [thread overview] Message-ID: <17d72b1b-0ac1-0f72-c72e-ff0f1f2d69f6@tarantool.org> (raw) In-Reply-To: <acbce4444d9b3b769a59f99cec8b0ad7f0488acb.1693236068.git.m.kokryashkin@tarantool.org> Hi, Max thanks for the patch! LGTM with a two minor comments. It is not related to submitted patches, but anyway - there is a typo: --- a/test/tarantool-tests/misclib-memprof-lapi.test.lua +++ b/test/tarantool-tests/misclib-memprof-lapi.test.lua @@ -36,7 +36,7 @@ local function default_payload() -- Preallocate table to avoid table array part reallocations. local _ = table_new(20, 0) - -- Want too see 20 objects here. + -- Want to see 20 objects here. for i = 1, 20 do -- Try to avoid crossing with "test" module objects. _[i] = "memprof-str-"..i On 8/28/23 18:23, Maxim Kokryashkin wrote: > This patch refactors symbol resolution in memprof, so > now they are resolved during the process of parsing. > This makes the generation mechanism excessive since > symtab updates are no longer affecting the previous events. > > Follows up tarantool/tarantool#8700 > --- > .../misclib-memprof-lapi.test.lua | 73 +++++-------------- > tools/memprof/humanize.lua | 16 ++-- > tools/memprof/parse.lua | 2 +- > tools/memprof/process.lua | 8 +- > 4 files changed, 31 insertions(+), 68 deletions(-) > > diff --git a/test/tarantool-tests/misclib-memprof-lapi.test.lua b/test/tarantool-tests/misclib-memprof-lapi.test.lua > index 3cb5c8be..0eee4e21 100644 > --- a/test/tarantool-tests/misclib-memprof-lapi.test.lua > +++ b/test/tarantool-tests/misclib-memprof-lapi.test.lua > @@ -78,7 +78,7 @@ local function generate_parsed_output(payload) > -- We don't need it any more. > os.remove(TMP_BINFILE) > > - return symbols, events > + return events > end > > local function form_source_line(line, source) > @@ -86,44 +86,13 @@ local function form_source_line(line, source) > end > > local function form_trace_line(traceno, line, source) > - return ("TRACE [%d] %s:%d"):format(traceno, source or SRC_PATH, line) > + return ("TRACE [%d] started at %s:%d"):format(traceno, source or SRC_PATH, line) > end Nit: this change is not relevant. In the branch hunk is different: @@ -86,44 +86,17 @@ local function form_source_line(line, source) end local function form_trace_line(traceno, line, source) - return ("TRACE [%d] %s:%d"):format(traceno, source or SRC_PATH, line) + return ("TRACE [%d] started at %s:%d"):format( + traceno, + source or SRC_PATH, + line + ) end > <snipped>
next prev parent reply other threads:[~2023-09-05 11:47 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-08-28 15:23 [Tarantool-patches] [PATCH luajit 0/2] profilers: purge generations Maxim Kokryashkin via Tarantool-patches 2023-08-28 15:23 ` [Tarantool-patches] [PATCH luajit 1/2] memprof: refactor symbol resolution Maxim Kokryashkin via Tarantool-patches 2023-09-03 10:14 ` Sergey Kaplun via Tarantool-patches 2023-09-04 5:44 ` Maxim Kokryashkin via Tarantool-patches 2023-09-05 11:47 ` Sergey Bronnikov via Tarantool-patches [this message] 2023-09-08 11:04 ` Maxim Kokryashkin via Tarantool-patches 2023-10-06 14:52 ` Sergey Bronnikov via Tarantool-patches 2023-08-28 15:23 ` [Tarantool-patches] [PATCH luajit 2/2] profilers: purge generation mechanism Maxim Kokryashkin via Tarantool-patches 2023-09-03 10:21 ` Sergey Kaplun via Tarantool-patches 2023-09-04 5:47 ` Maxim Kokryashkin via Tarantool-patches 2023-09-05 11:53 ` Sergey Bronnikov via Tarantool-patches 2023-09-12 10:26 ` Maxim Kokryashkin via Tarantool-patches 2023-09-14 9:47 ` Sergey Bronnikov via Tarantool-patches 2023-09-18 9:18 ` Maxim Kokryashkin via Tarantool-patches 2023-10-06 14:43 ` Sergey Bronnikov via Tarantool-patches 2023-10-06 14:45 ` Sergey Bronnikov via Tarantool-patches 2023-10-06 14:40 ` Sergey Bronnikov via Tarantool-patches 2023-10-06 14:52 ` Sergey Bronnikov via Tarantool-patches 2023-11-13 18:48 ` Igor Munkin via Tarantool-patches 2023-11-23 6:32 ` [Tarantool-patches] [PATCH luajit 0/2] profilers: purge generations Igor Munkin via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=17d72b1b-0ac1-0f72-c72e-ff0f1f2d69f6@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=max.kokryashkin@gmail.com \ --cc=sergeyb@tarantool.org \ --cc=skaplun@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH luajit 1/2] memprof: refactor symbol resolution' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox