Re: [Tarantool-patches] [PATCH luajit] FFI: Shrink container of packed bitfield.

[Evgeniy Temirgaleev via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

[-- Attachment #1: Type: text/plain, Size: 2227 bytes --]

Hi, Sergey!

Thanks for updating the test!

LGTM.
--
Best regards,
Evgeniy Temirgaleev

> 
> From: Sergey Kaplun <skaplun@tarantool.org>
> To: Evgeniy Temirgaleev <e.temirgaleev@tarantool.org>
> Cc: tarantool-patches@dev.tarantool.org, Sergey Bronnikov <sergeyb@tarantool.org
> >
> Date: Wednesday, July 29, 2026 8:04 PM +03:00
> Evgeniy,
> 
> On 29.07.26, Evgeniy Temirgaleev wrote:
> > Hi, Sergey!
> > Please, consider the idea about marking the tests with special build
> options.
> 
> Fixed your comment and force-pushed the branch.
> 
> <snipped>
> 
> >
> > I thinks it will be better to include such information to the test’s
> code in a some way.
> > For example, we can add comments to the code, which we expect to fail
> with ASAN checks. Also, we can add mark to the corresponding test
> condition messages with ‘ASAN’ to reflect this in the test reports.
> 
> Good idea! I've added the ASAN tag in the test description as you
> suggested and added the corresponding comment.
> 
> ===================================================================
> diff --git a/test/tarantool-tests/lj-1451-ffi-packed-bitfield.test.lua
> b/test/tarantool-tests/lj-1451-ffi-packed-bitfield.test.lua
> index 76483b0d..8b4e5ce8 100644
> --- a/test/tarantool-tests/lj-1451-ffi-packed-bitfield.test.lua
> +++ b/test/tarantool-tests/lj-1451-ffi-packed-bitfield.test.lua
> @@ -28,10 +28,13 @@ test:plan(5)
> 
> local packed = ffi.new('packed_struct')
> 
> -test:is(packed.bitfield, 0, 'correct 0-initialization')
> +-- Check that there is no heap overflow for the packed FFI
> +-- structure. That read/write access leads to the failure when
> +-- LuaJIT is built with ASAN support.
> +test:is(packed.bitfield, 0, 'ASAN: correct 0-initialization')
> 
> packed.bitfield = 1
> -test:is(packed.bitfield, 1, 'bitfield set correctly')
> +test:is(packed.bitfield, 1, 'ASAN: bitfield set correctly')
> 
> -- Check correct structure layout.
> local byteoffset, bitpos, bitsize = ffi.offsetof('packed_struct2',
> 'bitfield16')
> ===================================================================
> 
> Branch is force-pushed.
> 
> <snipped>
> 
> >
> > --
> > Best regards,
> > Evgeniy Temirgaleev
> 
> --
> Best regards,
> Sergey Kaplun
>

[-- Attachment #2: Type: text/html, Size: 3081 bytes --]