[tarantool-patches] Re: [PATCH] Do not enable commit if read_only = true

["Георгий Кириченко" <georgy@tarantool.org>]

[-- Attachment #1: Type: text/plain, Size: 923 bytes --]

On Thursday, February 28, 2019 1:25:30 PM MSK Konstantin Osipov wrote:
> * Vladimir Davydov <vdavydov.dev@gmail.com> [19/02/27 12:26]:
> > On Wed, Feb 27, 2019 at 10:36:00AM +0300, Georgy Kirichenko wrote:
> > > Disable commit if server is in read only mode.
> > 
> > The commit message is very poor. Please elaborate why this is important.
> 
> Having thought about it we should go over all in-flight
> transactions in vinyl and abort them.
> 
> We already use this approach on DDL.
> We could make it more general.
I did a little investigation and found that current implementation does not 
allow us do reach expected behavior using vinyl aborts because of
* transaction placed in the write set only after uniqueness check - this leads 
to a race if read only was set during this check.
* it is valid only for vy_update and vy_upsert invocations.
* ddl could stuck at schema_latch and continues after read_only was set.

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 488 bytes --]