From: Georgy Kirichenko <georgy@tarantool.org>
To: Ilya Markov <imarkov@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [wal 1/1] wal: Update request header after sequence update
Date: Wed, 18 Apr 2018 10:10:39 +0300 [thread overview]
Message-ID: <1774392.XyMLadrm1s@home.lan> (raw)
In-Reply-To: <c582937d2c9698cc2b63ec6895a78e45410b90aa.1523950414.git.imarkov@tarantool.org>
[-- Attachment #1: Type: text/plain, Size: 561 bytes --]
Seems good for me
Thanks for investigation
On Tuesday, April 17, 2018 10:39:16 AM MSK Ilya Markov wrote:
> When tuple in insert/replace request has NULL value
> in the field incremented by sequence,
> request body is changed, NULL is replaced by value taken from
> sequence.
> But request header is not updated.
> So Redo log, which takes body from header if header exists,
> writes the old version of request to wal.
>
> Fixed this with updating header value after handling the sequence.
>
> Closes #3247
> ---
> branch gh-3247-wrong-sequence-primary-index
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-04-18 7:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-17 7:39 [tarantool-patches] " Ilya Markov
2018-04-18 7:10 ` Georgy Kirichenko [this message]
2018-04-18 11:47 ` Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1774392.XyMLadrm1s@home.lan \
--to=georgy@tarantool.org \
--cc=imarkov@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [wal 1/1] wal: Update request header after sequence update' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox