From: Maxim Kokryashkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: "Sergey Kaplun" <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit] x64: Properly fix __call metamethod return dispatch.
Date: Tue, 07 Nov 2023 15:06:50 +0300 [thread overview]
Message-ID: <1699358810.367209442@f309.i.mail.ru> (raw)
In-Reply-To: <ZUobQ12mMJKM27Z0@root>
[-- Attachment #1: Type: text/plain, Size: 1683 bytes --]
Hi, Sergey!
Thanks for the patch!
LGTM
--
Best regards,
Maxim Kokryashkin
>Вторник, 7 ноября 2023, 14:15 +03:00 от Sergey Kaplun <skaplun@tarantool.org>:
>
>Hi, Igor!
>Thanks for the review!
>Fixed the nit and force-pushed the branch.
>
>On 07.11.23, Igor Munkin wrote:
>> Sergey,
>>
>> Thanks for the patch! LGTM as obvious, except the single nit regarding
>> the commit message.
>>
>> On 07.11.23, Sergey Kaplun wrote:
>> > From: Mike Pall <mike>
>> >
>> > Reported by Sergey Kaplun.
>> >
>> > (cherry-picked from commit d133d67c881f363f0b5584ebd21a965eb3435aa1)
>> >
>> > This patch is the follow-up for the commit
>> > 1672bdc0ffbee9f32fadb6943909d6af7eb9a7b1 ("x64: Fix __call metamethod
>> > return dispatch."). This patch uses the incorrect macro x64 (which is
>>
>> I don't get which one of the aforementioned patches is "this": *this*
>> one fixing the issue, or *that* one, that doesn't.
>
>Fixed to "That", as you suggested. Force-pushed the branch.
>
>>
>
><snipped>
>
>> > diff --git a/src/vm_x86.dasc b/src/vm_x86.dasc
>> > index 9fa9a3f7..6a353796 100644
>> > --- a/src/vm_x86.dasc
>> > +++ b/src/vm_x86.dasc
>> > @@ -1451,7 +1451,7 @@ static void build_subroutines(BuildCtx *ctx)
>> > | mov LFUNC:RB, [RA-8]
>> > | add NARGS:RD, 1
>> > | // This is fragile. L->base must not move, KBASE must always be defined.
>> > - |.if x64
>> > + |.if X64
>>
>> Bonjour.
>
>Aah! Et bonjour mes nouveaux (espérons-le) amis !
>
>>
>> > | cmp KBASEa, rdx // Continue with CALLT if flag set.
>> > |.else
>> > | cmp KBASE, BASE // Continue with CALLT if flag set.
>> > --
>> > 2.42.0
>> >
>>
>> --
>> Best regards,
>> IM
>
>--
>Best regards,
>Sergey Kaplun
[-- Attachment #2: Type: text/html, Size: 2452 bytes --]
next prev parent reply other threads:[~2023-11-07 12:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-07 10:54 Sergey Kaplun via Tarantool-patches
2023-11-07 11:05 ` Igor Munkin via Tarantool-patches
2023-11-07 11:10 ` Sergey Kaplun via Tarantool-patches
2023-11-07 12:06 ` Maxim Kokryashkin via Tarantool-patches [this message]
2023-11-23 6:29 ` Igor Munkin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1699358810.367209442@f309.i.mail.ru \
--to=tarantool-patches@dev.tarantool.org \
--cc=m.kokryashkin@tarantool.org \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit] x64: Properly fix __call metamethod return dispatch.' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox