From: Maxim Kokryashkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: "Sergey Kaplun" <skaplun@tarantool.org>
Cc: "Sergey Bronnikov" <estetus@gmail.com>,
tarantool-patches@dev.tarantool.org, max.kokryashkin@gmail.com
Subject: Re: [Tarantool-patches] [PATCH luajit] LJ_GC64: Always snapshot functions for non-base frames.
Date: Tue, 07 Nov 2023 13:54:22 +0300 [thread overview]
Message-ID: <1699354462.333135142@f275.i.mail.ru> (raw)
In-Reply-To: <ZTaGdCv3eyESAf9G@root>
[-- Attachment #1: Type: text/plain, Size: 612 bytes --]
Hi!
Thanks for the clarification.
Sergey B., thanks for the fixes.
LGTM after fixing comments left by Sergey K.
--
Best regards,
Maxim Kokryashkin
>Понедельник, 23 октября 2023, 17:47 +03:00 от Sergey Kaplun <skaplun@tarantool.org>:
>
>Hi, Maxim!
>Thanks for the review!
>
>> I like this repro much more. It is easier to understand than the first one.
>> What's the motivation behind having two tests for the same issue?
>The main motivation point is to check the behaviour the side trace from
>the side exit, not only the stitched one.
>
>--
>Best regards,
>Sergey Kaplun
[-- Attachment #2: Type: text/html, Size: 1144 bytes --]
next prev parent reply other threads:[~2023-11-07 10:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-12 13:06 Sergey Bronnikov via Tarantool-patches
2023-10-17 14:56 ` Maxim Kokryashkin via Tarantool-patches
2023-10-18 14:59 ` Sergey Bronnikov via Tarantool-patches
2023-10-23 14:43 ` Sergey Kaplun via Tarantool-patches
2023-11-07 10:54 ` Maxim Kokryashkin via Tarantool-patches [this message]
2023-10-23 14:57 ` Sergey Kaplun via Tarantool-patches
2024-02-12 7:36 ` Sergey Kaplun via Tarantool-patches
2024-02-13 8:30 ` Sergey Bronnikov via Tarantool-patches
2024-02-13 10:58 ` Maxim Kokryashkin via Tarantool-patches
2024-02-15 13:39 ` Igor Munkin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1699354462.333135142@f275.i.mail.ru \
--to=tarantool-patches@dev.tarantool.org \
--cc=estetus@gmail.com \
--cc=m.kokryashkin@tarantool.org \
--cc=max.kokryashkin@gmail.com \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit] LJ_GC64: Always snapshot functions for non-base frames.' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox