From: Maxim Kokryashkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: "Sergey Bronnikov" <estetus@gmail.com>
Cc: max.kokryashkin@gmail.com, tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit 2/4][v2] test: fix codestyle
Date: Thu, 12 Oct 2023 13:34:22 +0300 [thread overview]
Message-ID: <1697106862.473388937@f463.i.mail.ru> (raw)
In-Reply-To: <f881dbec63a19c3a0a7885979de3beb84c05ad56.1697042800.git.sergeyb@tarantool.org>
[-- Attachment #1: Type: text/plain, Size: 2122 bytes --]
Hi, Sergey!
Thanks for the patch!
LGTM
--
Best regards,
Maxim Kokryashkin
>Среда, 11 октября 2023, 19:54 +03:00 от Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>:
>
>From: Sergey Bronnikov < sergeyb@tarantool.org >
>
>This patch fixes warnings found by the checkpatch.pl script.
>---
> test/tarantool-c-tests/CMakeLists.txt | 1 -
> test/tarantool-c-tests/test.c | 2 +-
> test/tarantool-tests/lj-356-ir-khash-non-string-obj.test.lua | 2 +-
> 3 files changed, 2 insertions(+), 3 deletions(-)
>
>diff --git a/test/tarantool-c-tests/CMakeLists.txt b/test/tarantool-c-tests/CMakeLists.txt
>index 17255345..4b1d8832 100644
>--- a/test/tarantool-c-tests/CMakeLists.txt
>+++ b/test/tarantool-c-tests/CMakeLists.txt
>@@ -66,4 +66,3 @@ add_custom_command(TARGET tarantool-c-tests
> ${C_TEST_FLAGS}
> WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}
> )
>-
>diff --git a/test/tarantool-c-tests/test.c b/test/tarantool-c-tests/test.c
>index 74cba3a3..7907c12a 100644
>--- a/test/tarantool-c-tests/test.c
>+++ b/test/tarantool-c-tests/test.c
>@@ -164,7 +164,7 @@ static void test_diagnostic(void)
> while ((ent_end = strchr(ent, '\n')) != NULL) {
> char *next_ent = ent_end + 1;
> /*
>- * Limit string with with the zero byte for
>+ * Limit string with the zero byte for
> * formatted output. Anyway, don't need this \n
> * anymore.
> */
>diff --git a/test/tarantool-tests/lj-356-ir-khash-non-string-obj.test.lua b/test/tarantool-tests/lj-356-ir-khash-non-string-obj.test.lua
>index 5159ac32..ee0f5583 100644
>--- a/test/tarantool-tests/lj-356-ir-khash-non-string-obj.test.lua
>+++ b/test/tarantool-tests/lj-356-ir-khash-non-string-obj.test.lua
>@@ -85,7 +85,7 @@ test:ok(not traceinfo(2), 'the second trace should not be compiled')
> jit.on()
>
> for i = 1, N_ITERATIONS do
>- -- Check that that all lookups are correct and there is no
>+ -- Check that all lookups are correct and there is no
> -- value from other cdata stored in the table.
> test:ok(result_tab[i] == MAGIC, 'correct hash lookup from the table')
> end
>--
>2.34.1
[-- Attachment #2: Type: text/html, Size: 2829 bytes --]
next prev parent reply other threads:[~2023-10-12 10:34 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-11 16:52 [Tarantool-patches] [PATCH luajit 0/4][v2] Fix typos and enable codespell Sergey Bronnikov via Tarantool-patches
2023-10-11 16:52 ` [Tarantool-patches] [PATCH luajit 1/4][v2] codehealth: fix typos Sergey Bronnikov via Tarantool-patches
2023-10-12 10:33 ` Maxim Kokryashkin via Tarantool-patches
2023-10-23 8:50 ` Sergey Kaplun via Tarantool-patches
2023-10-11 16:52 ` [Tarantool-patches] [PATCH luajit 2/4][v2] test: fix codestyle Sergey Bronnikov via Tarantool-patches
2023-10-12 10:34 ` Maxim Kokryashkin via Tarantool-patches [this message]
2023-10-23 8:52 ` Sergey Kaplun via Tarantool-patches
2023-10-23 14:13 ` Sergey Bronnikov via Tarantool-patches
2023-10-23 14:27 ` Sergey Kaplun via Tarantool-patches
2023-10-11 16:52 ` [Tarantool-patches] [PATCH luajit 3/4][v2] cmake: introduce target with codespell Sergey Bronnikov via Tarantool-patches
2023-10-11 19:33 ` Sergey Bronnikov via Tarantool-patches
2023-10-12 10:43 ` Maxim Kokryashkin via Tarantool-patches
2023-10-12 13:28 ` Sergey Bronnikov via Tarantool-patches
2023-10-12 18:46 ` Maxim Kokryashkin via Tarantool-patches
2023-10-17 14:50 ` Sergey Bronnikov via Tarantool-patches
2023-10-23 9:20 ` Sergey Kaplun via Tarantool-patches
2023-10-23 12:29 ` Sergey Bronnikov via Tarantool-patches
2023-10-23 14:38 ` Sergey Kaplun via Tarantool-patches
2023-10-31 6:42 ` Sergey Kaplun via Tarantool-patches
2023-10-31 10:50 ` Sergey Bronnikov via Tarantool-patches
2023-10-31 11:31 ` Sergey Kaplun via Tarantool-patches
2023-10-31 11:53 ` Maxim Kokryashkin via Tarantool-patches
2023-10-11 16:52 ` [Tarantool-patches] [PATCH luajit 4/4][v2] ci: enable codespell Sergey Bronnikov via Tarantool-patches
2023-10-12 10:45 ` Maxim Kokryashkin via Tarantool-patches
2023-10-23 8:53 ` Sergey Kaplun via Tarantool-patches
2023-11-16 16:19 ` [Tarantool-patches] [PATCH luajit 0/4][v2] Fix typos and " Igor Munkin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1697106862.473388937@f463.i.mail.ru \
--to=tarantool-patches@dev.tarantool.org \
--cc=estetus@gmail.com \
--cc=m.kokryashkin@tarantool.org \
--cc=max.kokryashkin@gmail.com \
--subject='Re: [Tarantool-patches] [PATCH luajit 2/4][v2] test: fix codestyle' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox