From: Maxim Kokryashkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: "Sergey Bronnikov" <sergeyb@tarantool.org>
Cc: "Maxim Kokryashkin" <max.kokryashkin@gmail.com>,
tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit v9 1/2] tools: add cli flag to run profile dump parsers
Date: Wed, 04 Oct 2023 14:49:55 +0300 [thread overview]
Message-ID: <1696420195.338290270@f488.i.mail.ru> (raw)
In-Reply-To: <4bee35bb-7b49-4f33-9e8f-0b535c31fdae@tarantool.org>
[-- Attachment #1: Type: text/plain, Size: 1562 bytes --]
Hi!
Here you go: https://github.com/tarantool/tarantool/issues/9217
--
Best regards,
Maxim Kokryashkin
>Среда, 4 октября 2023, 11:58 +03:00 от Sergey Bronnikov <sergeyb@tarantool.org>:
>
>
>On 9/18/23 11:51, Maxim Kokryashkin wrote:
>>Hi!
>>
>>>Четверг, 14 сентября 2023, 12:22 +03:00 от Sergey Bronnikov <sergeyb@tarantool.org> :
>>>
>>>Hi, Max
>>>
>>>Thanks for the fixes!
>>>
>>>Two new comments:
>>>
>>>$ ./build/src/luajit -ts sysprof.bin
>>>./build/src/luajit: ./tools/utils/symtab.lua:107: attempt to concatenate
>>>local 'magic' (a nil value)
>>Works just fine for me. Make sure you are using the right file.
>
>$ ./build/src/luajit -ts sysprof.bin
>$ file sysprof.bin
>sysprof.bin: empty
>$ ./build/src/luajit -ts sysprof.bin
>./build/src/luajit: ./tools/utils/symtab.lua:107: attempt to concatenate local 'magic' (a nil value)
>$
>
>>>
>>>Please fix.
>>>
>>>
>>>$ ./build/src/luajit -ts mee
>>>./build/src/luajit: ./tools/utils/bufread.lua:122: fopen, errno: 2
>>>
>>>
>>>Seems the case is not handled in your code, let's fix it.
>>It is not relevant to flags and should be fixed for both the memprof
>>and the sysprof in a separate ticket with refactoring.
>I have no objections, what is a number of the ticket?
>
>>
>>>
>>>On 9/12/23 23:03, Maxim Kokryashkin wrote:
>>>> Hi, Sergey!
>>>> Thanks for the review!
>>>> Fixed all of your comments, except for the one about
>>>> `luacheckrc` and _TARANTOOL. I believe, it should be
>>>> done in a separate patch.
>>>> <snipped>
>>
[-- Attachment #2: Type: text/html, Size: 3200 bytes --]
next prev parent reply other threads:[~2023-10-04 11:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-31 11:35 [Tarantool-patches] [PATCH luajit v9 0/2] introduce cli for tools Maxim Kokryashkin via Tarantool-patches
2023-08-31 11:35 ` [Tarantool-patches] [PATCH luajit v9 1/2] tools: add cli flag to run profile dump parsers Maxim Kokryashkin via Tarantool-patches
2023-09-03 9:50 ` Sergey Kaplun via Tarantool-patches
2023-09-04 9:30 ` Maxim Kokryashkin via Tarantool-patches
2023-09-07 9:41 ` Sergey Bronnikov via Tarantool-patches
2023-09-12 20:03 ` Maxim Kokryashkin via Tarantool-patches
2023-09-14 9:22 ` Sergey Bronnikov via Tarantool-patches
2023-09-18 8:51 ` Maxim Kokryashkin via Tarantool-patches
2023-10-04 8:58 ` Sergey Bronnikov via Tarantool-patches
2023-10-04 11:49 ` Maxim Kokryashkin via Tarantool-patches [this message]
2023-10-06 8:26 ` Sergey Bronnikov via Tarantool-patches
2023-11-23 6:33 ` Igor Munkin via Tarantool-patches
2023-08-31 11:35 ` [Tarantool-patches] [PATCH luajit v9 2/2] test: don't skip tool CLI flag for tarantool Maxim Kokryashkin via Tarantool-patches
2023-09-03 9:54 ` Sergey Kaplun via Tarantool-patches
2023-09-07 9:42 ` Sergey Bronnikov via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1696420195.338290270@f488.i.mail.ru \
--to=tarantool-patches@dev.tarantool.org \
--cc=m.kokryashkin@tarantool.org \
--cc=max.kokryashkin@gmail.com \
--cc=sergeyb@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit v9 1/2] tools: add cli flag to run profile dump parsers' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox