Re: [Tarantool-patches] [PATCH luajit 1/2] Fix frame for on-trace out-of-memory error.

[Maxim Kokryashkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

[-- Attachment #1: Type: text/plain, Size: 2079 bytes --]


Hi!
Thanks for the review!
Fixed your comments, branch is force-pushed, here is the diff:
 
diff --git a/test/tarantool-tests/lj-1004-oom-error-frame/testoomframe.c b/test/tarantool-tests/lj-1004-oom-error-frame/testoomframe.c
index dbfe17db..82f64f01 100644
--- a/test/tarantool-tests/lj-1004-oom-error-frame/testoomframe.c
+++ b/test/tarantool-tests/lj-1004-oom-error-frame/testoomframe.c
@@ -1,7 +1,8 @@
 #include "lua.h"
 #include "lauxlib.h"
 
-static int allocate_userdata(lua_State *L) {
+static int allocate_userdata(lua_State *L)
+{
     lua_newuserdata(L, 1);
     return 1;
 }
@@ -11,7 +12,8 @@ static const struct luaL_Reg testoomframe[] = {
     {NULL, NULL}
 };
 
-LUA_API int luaopen_testoomframe(lua_State *L) {
+LUA_API int luaopen_testoomframe(lua_State *L)
+{
     luaL_register(L, "testoomframe", testoomframe);
     return 1;
 }
 
--
Best regards,
Maxim Kokryashkin
 
  
>Понедельник, 11 сентября 2023, 11:09 +03:00 от Sergey Kaplun <skaplun@tarantool.org>:
> 
>Hi, Maxim!
>Thanks for the patch!
>LGTM, just two minor nits below.
>
>On 05.09.23, Maxim Kokryashkin wrote:
>> Reported by ruidong007.
>
><snipped>
>
>> diff --git a/test/tarantool-tests/lj-1004-oom-error-frame/testoomframe.c b/test/tarantool-tests/lj-1004-oom-error-frame/testoomframe.c
>> new file mode 100644
>> index 00000000..a54eac63
>> --- /dev/null
>> +++ b/test/tarantool-tests/lj-1004-oom-error-frame/testoomframe.c
>> @@ -0,0 +1,17 @@
>> +#include <lua.h>
>> +#include <lauxlib.h>
>> +
>> +static int allocate_userdata(lua_State *L) {
>
>Nit: Please, start function's block from the new line, i.e:
>
>| {
>| lua_newuserdata(L, 1);
>| return 1;
>| }
>
>> + lua_newuserdata(L, 1);
>> + return 1;
>> +}
>> +
>> +static const struct luaL_Reg testoomframe[] = {
>> + {"allocate_userdata", allocate_userdata},
>> + {NULL, NULL}
>> +};
>> +
>> +LUA_API int luaopen_testoomframe(lua_State *L) {
>
>Ditto.
>
>> + luaL_register(L, "testoomframe", testoomframe);
>> + return 1;
>> +}
>> --
>> 2.41.0
>>
>
>--
>Best regards,
>Sergey Kaplun
 

[-- Attachment #2: Type: text/html, Size: 3109 bytes --]