From: Maxim Kokryashkin via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: "Sergey Kaplun" <skaplun@tarantool.org> Cc: "Maxim Kokryashkin" <max.kokryashkin@gmail.com>, tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH luajit 1/2] Fix frame for on-trace out-of-memory error. Date: Mon, 11 Sep 2023 14:52:40 +0300 [thread overview] Message-ID: <1694433160.149924067@f183.i.mail.ru> (raw) In-Reply-To: <ZP7KDDSGFV6DbPv7@root> [-- Attachment #1: Type: text/plain, Size: 2079 bytes --] Hi! Thanks for the review! Fixed your comments, branch is force-pushed, here is the diff: diff --git a/test/tarantool-tests/lj-1004-oom-error-frame/testoomframe.c b/test/tarantool-tests/lj-1004-oom-error-frame/testoomframe.c index dbfe17db..82f64f01 100644 --- a/test/tarantool-tests/lj-1004-oom-error-frame/testoomframe.c +++ b/test/tarantool-tests/lj-1004-oom-error-frame/testoomframe.c @@ -1,7 +1,8 @@ #include "lua.h" #include "lauxlib.h" -static int allocate_userdata(lua_State *L) { +static int allocate_userdata(lua_State *L) +{ lua_newuserdata(L, 1); return 1; } @@ -11,7 +12,8 @@ static const struct luaL_Reg testoomframe[] = { {NULL, NULL} }; -LUA_API int luaopen_testoomframe(lua_State *L) { +LUA_API int luaopen_testoomframe(lua_State *L) +{ luaL_register(L, "testoomframe", testoomframe); return 1; } -- Best regards, Maxim Kokryashkin >Понедельник, 11 сентября 2023, 11:09 +03:00 от Sergey Kaplun <skaplun@tarantool.org>: > >Hi, Maxim! >Thanks for the patch! >LGTM, just two minor nits below. > >On 05.09.23, Maxim Kokryashkin wrote: >> Reported by ruidong007. > ><snipped> > >> diff --git a/test/tarantool-tests/lj-1004-oom-error-frame/testoomframe.c b/test/tarantool-tests/lj-1004-oom-error-frame/testoomframe.c >> new file mode 100644 >> index 00000000..a54eac63 >> --- /dev/null >> +++ b/test/tarantool-tests/lj-1004-oom-error-frame/testoomframe.c >> @@ -0,0 +1,17 @@ >> +#include <lua.h> >> +#include <lauxlib.h> >> + >> +static int allocate_userdata(lua_State *L) { > >Nit: Please, start function's block from the new line, i.e: > >| { >| lua_newuserdata(L, 1); >| return 1; >| } > >> + lua_newuserdata(L, 1); >> + return 1; >> +} >> + >> +static const struct luaL_Reg testoomframe[] = { >> + {"allocate_userdata", allocate_userdata}, >> + {NULL, NULL} >> +}; >> + >> +LUA_API int luaopen_testoomframe(lua_State *L) { > >Ditto. > >> + luaL_register(L, "testoomframe", testoomframe); >> + return 1; >> +} >> -- >> 2.41.0 >> > >-- >Best regards, >Sergey Kaplun [-- Attachment #2: Type: text/html, Size: 3109 bytes --]
next prev parent reply other threads:[~2023-09-11 11:52 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-09-05 10:39 [Tarantool-patches] [PATCH luajit 0/2] Fix frames for on trace errors Maxim Kokryashkin via Tarantool-patches 2023-09-05 10:39 ` [Tarantool-patches] [PATCH luajit 1/2] Fix frame for on-trace out-of-memory error Maxim Kokryashkin via Tarantool-patches 2023-09-07 8:07 ` Sergey Bronnikov via Tarantool-patches 2023-09-08 13:18 ` Maxim Kokryashkin via Tarantool-patches 2023-09-12 9:53 ` Sergey Bronnikov via Tarantool-patches 2023-09-11 8:04 ` Sergey Kaplun via Tarantool-patches 2023-09-11 11:52 ` Maxim Kokryashkin via Tarantool-patches [this message] 2023-09-05 10:39 ` [Tarantool-patches] [PATCH luajit 2/2] Fix frame for more types of on-trace error messages Maxim Kokryashkin via Tarantool-patches 2023-09-07 8:11 ` Sergey Bronnikov via Tarantool-patches 2023-09-07 8:56 ` Maxim Kokryashkin via Tarantool-patches 2023-09-07 10:06 ` Sergey Bronnikov via Tarantool-patches 2023-09-11 8:20 ` Sergey Kaplun via Tarantool-patches 2023-09-11 13:45 ` Maxim Kokryashkin via Tarantool-patches 2023-09-27 12:33 ` [Tarantool-patches] [PATCH luajit 0/2] Fix frames for on trace errors Igor Munkin via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1694433160.149924067@f183.i.mail.ru \ --to=tarantool-patches@dev.tarantool.org \ --cc=m.kokryashkin@tarantool.org \ --cc=max.kokryashkin@gmail.com \ --cc=skaplun@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH luajit 1/2] Fix frame for on-trace out-of-memory error.' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox