Tarantool development patches archive
 help / color / mirror / Atom feed
From: Maxim Kokryashkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: "Sergey Bronnikov" <estetus@gmail.com>
Cc: max.kokryashkin@gmail.com, tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches]  [PATCH 5/5][v3] test: fix codestyle
Date: Thu, 03 Aug 2023 22:45:04 +0300	[thread overview]
Message-ID: <1691091904.744377050@f148.i.mail.ru> (raw)
In-Reply-To: <d20358c593344176f18770d7d49e09a5319236d1.1690966149.git.sergeyb@tarantool.org>

[-- Attachment #1: Type: text/plain, Size: 2220 bytes --]


Hi, Sergey!
LGTM, except for a commit message.
I think it would be better to rephrase it like the following:
| This patch fixes warnings found by the checkpatch.pl script.
--
Best regards,
Maxim Kokryashkin
 
  
>Среда, 2 августа 2023, 11:58 +03:00 от Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>:
> 
>From: Sergey Bronnikov < sergeyb@tarantool.org >
>
>Warnings found by checkpatch.
>---
> test/tarantool-c-tests/CMakeLists.txt | 1 -
> test/tarantool-c-tests/test.c | 2 +-
> test/tarantool-tests/lj-356-ir-khash-non-string-obj.test.lua | 2 +-
> 3 files changed, 2 insertions(+), 3 deletions(-)
>
>diff --git a/test/tarantool-c-tests/CMakeLists.txt b/test/tarantool-c-tests/CMakeLists.txt
>index 17255345..4b1d8832 100644
>--- a/test/tarantool-c-tests/CMakeLists.txt
>+++ b/test/tarantool-c-tests/CMakeLists.txt
>@@ -66,4 +66,3 @@ add_custom_command(TARGET tarantool-c-tests
>     ${C_TEST_FLAGS}
>   WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}
> )
>-
>diff --git a/test/tarantool-c-tests/test.c b/test/tarantool-c-tests/test.c
>index 74cba3a3..7907c12a 100644
>--- a/test/tarantool-c-tests/test.c
>+++ b/test/tarantool-c-tests/test.c
>@@ -164,7 +164,7 @@ static void test_diagnostic(void)
>  while ((ent_end = strchr(ent, '\n')) != NULL) {
>  char *next_ent = ent_end + 1;
>  /*
>- * Limit string with with the zero byte for
>+ * Limit string with the zero byte for
>  * formatted output. Anyway, don't need this \n
>  * anymore.
>  */
>diff --git a/test/tarantool-tests/lj-356-ir-khash-non-string-obj.test.lua b/test/tarantool-tests/lj-356-ir-khash-non-string-obj.test.lua
>index 5159ac32..ee0f5583 100644
>--- a/test/tarantool-tests/lj-356-ir-khash-non-string-obj.test.lua
>+++ b/test/tarantool-tests/lj-356-ir-khash-non-string-obj.test.lua
>@@ -85,7 +85,7 @@ test:ok(not traceinfo(2), 'the second trace should not be compiled')
> jit.on()
> 
> for i = 1, N_ITERATIONS do
>- -- Check that that all lookups are correct and there is no
>+ -- Check that all lookups are correct and there is no
>   -- value from other cdata stored in the table.
>   test:ok(result_tab[i] == MAGIC, 'correct hash lookup from the table')
> end
>--
>2.34.1
 

[-- Attachment #2: Type: text/html, Size: 2923 bytes --]

  reply	other threads:[~2023-08-03 19:45 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-02  8:52 [Tarantool-patches] [PATCH 0/5][v3] Fix typos and enable checkpatch Sergey Bronnikov via Tarantool-patches
2023-08-02  8:52 ` [Tarantool-patches] [PATCH 1/5][v3] ci: fix a step name Sergey Bronnikov via Tarantool-patches
2023-08-03 19:27   ` Maxim Kokryashkin via Tarantool-patches
2023-08-09 11:20   ` Sergey Kaplun via Tarantool-patches
2023-08-02  8:52 ` [Tarantool-patches] [PATCH 2/5][v3] codehealth: fix typos Sergey Bronnikov via Tarantool-patches
2023-08-03 19:29   ` Maxim Kokryashkin via Tarantool-patches
2023-08-09 12:58   ` Sergey Kaplun via Tarantool-patches
2023-08-09 14:41     ` Sergey Bronnikov via Tarantool-patches
2023-08-02  8:52 ` [Tarantool-patches] [PATCH 3/5][v3] cmake: introduce new targets Sergey Bronnikov via Tarantool-patches
2023-08-03 19:38   ` Maxim Kokryashkin via Tarantool-patches
2023-08-04 10:56     ` Sergey Bronnikov via Tarantool-patches
2023-08-09 14:04       ` Sergey Kaplun via Tarantool-patches
2023-08-09 14:55         ` Sergey Bronnikov via Tarantool-patches
2023-08-09 15:45           ` Sergey Kaplun via Tarantool-patches
2023-08-15  8:57           ` Maxim Kokryashkin via Tarantool-patches
2023-08-02  8:52 ` [Tarantool-patches] [PATCH 4/5][v3] ci: enable checkpatch Sergey Bronnikov via Tarantool-patches
2023-08-03 19:38   ` Maxim Kokryashkin via Tarantool-patches
2023-08-09 14:40   ` Sergey Kaplun via Tarantool-patches
2023-08-09 15:05     ` Sergey Bronnikov via Tarantool-patches
2023-08-14  9:22     ` Sergey Bronnikov via Tarantool-patches
2023-08-02  8:52 ` [Tarantool-patches] [PATCH 5/5][v3] test: fix codestyle Sergey Bronnikov via Tarantool-patches
2023-08-03 19:45   ` Maxim Kokryashkin via Tarantool-patches [this message]
2023-08-04 10:42     ` Sergey Bronnikov via Tarantool-patches
2023-08-09 14:07   ` Sergey Kaplun via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1691091904.744377050@f148.i.mail.ru \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=estetus@gmail.com \
    --cc=m.kokryashkin@tarantool.org \
    --cc=max.kokryashkin@gmail.com \
    --subject='Re: [Tarantool-patches]  [PATCH 5/5][v3] test: fix codestyle' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox