Re: [Tarantool-patches] [PATCH 5/5][v3] test: fix codestyle

[Maxim Kokryashkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

[-- Attachment #1: Type: text/plain, Size: 2220 bytes --]


Hi, Sergey!
LGTM, except for a commit message.
I think it would be better to rephrase it like the following:
| This patch fixes warnings found by the checkpatch.pl script.
--
Best regards,
Maxim Kokryashkin
 
  
>Среда, 2 августа 2023, 11:58 +03:00 от Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>:
> 
>From: Sergey Bronnikov < sergeyb@tarantool.org >
>
>Warnings found by checkpatch.
>---
> test/tarantool-c-tests/CMakeLists.txt | 1 -
> test/tarantool-c-tests/test.c | 2 +-
> test/tarantool-tests/lj-356-ir-khash-non-string-obj.test.lua | 2 +-
> 3 files changed, 2 insertions(+), 3 deletions(-)
>
>diff --git a/test/tarantool-c-tests/CMakeLists.txt b/test/tarantool-c-tests/CMakeLists.txt
>index 17255345..4b1d8832 100644
>--- a/test/tarantool-c-tests/CMakeLists.txt
>+++ b/test/tarantool-c-tests/CMakeLists.txt
>@@ -66,4 +66,3 @@ add_custom_command(TARGET tarantool-c-tests
>     ${C_TEST_FLAGS}
>   WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}
> )
>-
>diff --git a/test/tarantool-c-tests/test.c b/test/tarantool-c-tests/test.c
>index 74cba3a3..7907c12a 100644
>--- a/test/tarantool-c-tests/test.c
>+++ b/test/tarantool-c-tests/test.c
>@@ -164,7 +164,7 @@ static void test_diagnostic(void)
>  while ((ent_end = strchr(ent, '\n')) != NULL) {
>  char *next_ent = ent_end + 1;
>  /*
>- * Limit string with with the zero byte for
>+ * Limit string with the zero byte for
>  * formatted output. Anyway, don't need this \n
>  * anymore.
>  */
>diff --git a/test/tarantool-tests/lj-356-ir-khash-non-string-obj.test.lua b/test/tarantool-tests/lj-356-ir-khash-non-string-obj.test.lua
>index 5159ac32..ee0f5583 100644
>--- a/test/tarantool-tests/lj-356-ir-khash-non-string-obj.test.lua
>+++ b/test/tarantool-tests/lj-356-ir-khash-non-string-obj.test.lua
>@@ -85,7 +85,7 @@ test:ok(not traceinfo(2), 'the second trace should not be compiled')
> jit.on()
> 
> for i = 1, N_ITERATIONS do
>- -- Check that that all lookups are correct and there is no
>+ -- Check that all lookups are correct and there is no
>   -- value from other cdata stored in the table.
>   test:ok(result_tab[i] == MAGIC, 'correct hash lookup from the table')
> end
>--
>2.34.1
 

[-- Attachment #2: Type: text/html, Size: 2923 bytes --]