Re: [Tarantool-patches] [PATCH 4/5][v3] ci: enable checkpatch

[Maxim Kokryashkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

[-- Attachment #1: Type: text/plain, Size: 2158 bytes --]


Hi, Sergey!
Thanks for the patch!
LGTM
--
Best regards,
Maxim Kokryashkin
 
  
>Среда, 2 августа 2023, 11:58 +03:00 от Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>:
> 
>From: Sergey Bronnikov < sergeyb@tarantool.org >
>
>Patch adds a GitHub Action, that clones checkpatch repository, and adds
>a job, that runs checkpatch [1] using CMake target "LuaJIT-checkpatch"
>against commits on top of the master branch.
>
>1.  https://github.com/tarantool/checkpatch
>---
> .github/actions/checkpatch/action.yml | 11 +++++++++++
> .github/workflows/lint.yml | 20 ++++++++++++++++++++
> 2 files changed, 31 insertions(+)
> create mode 100644 .github/actions/checkpatch/action.yml
>
>diff --git a/.github/actions/checkpatch/action.yml b/.github/actions/checkpatch/action.yml
>new file mode 100644
>index 00000000..cd2cce62
>--- /dev/null
>+++ b/.github/actions/checkpatch/action.yml
>@@ -0,0 +1,11 @@
>+name: Setup checkpatch
>+description: Setup a script for checking for codestyle and grammar errors
>+runs:
>+ using: composite
>+ steps:
>+ - uses: actions/checkout@v3
>+ with:
>+ repository: tarantool/checkpatch
>+ path: 'checkpatch'
>+ - run: apt install -y codespell
>+ shell: bash
>diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
>index 8154a622..db3af975 100644
>--- a/.github/workflows/lint.yml
>+++ b/.github/workflows/lint.yml
>@@ -51,3 +51,23 @@ jobs:
>       - name: luacheck
>         run: cmake --build . --target LuaJIT-luacheck
>         working-directory: ${{ env.BUILDDIR }}
>+
>+ checkpatch:
>+ runs-on: [self-hosted, lightweight, Linux, x86_64]
>+
>+ steps:
>+ - uses: actions/checkout@v3
>+ with:
>+ fetch-depth: 0
>+ submodules: recursive
>+ - name: checkpatch
>+ uses: ./.github/actions/checkpatch
>+ - name: environment
>+ uses: ./.github/actions/setup
>+ - name: make tarantool/master available
>+ run: git checkout tarantool/master && git checkout -
>+ - name: configure
>+ run: cmake -S . -B ${{ env.BUILDDIR }}
>+ - name: checkpatch
>+ run: cmake --build . --target LuaJIT-checkpatch
>+ working-directory: ${{ env.BUILDDIR }}
>--
>2.34.1
 

[-- Attachment #2: Type: text/html, Size: 2956 bytes --]