From: Maxim Kokryashkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: "Sergey Bronnikov" <estetus@gmail.com>
Cc: max.kokryashkin@gmail.com, tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 4/5][v3] ci: enable checkpatch
Date: Thu, 03 Aug 2023 22:38:53 +0300 [thread overview]
Message-ID: <1691091533.804781541@f148.i.mail.ru> (raw)
In-Reply-To: <0b4e13bb2bfeea5812e9bb8cee02cb706c9f1175.1690966149.git.sergeyb@tarantool.org>
[-- Attachment #1: Type: text/plain, Size: 2158 bytes --]
Hi, Sergey!
Thanks for the patch!
LGTM
--
Best regards,
Maxim Kokryashkin
>Среда, 2 августа 2023, 11:58 +03:00 от Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>:
>
>From: Sergey Bronnikov < sergeyb@tarantool.org >
>
>Patch adds a GitHub Action, that clones checkpatch repository, and adds
>a job, that runs checkpatch [1] using CMake target "LuaJIT-checkpatch"
>against commits on top of the master branch.
>
>1. https://github.com/tarantool/checkpatch
>---
> .github/actions/checkpatch/action.yml | 11 +++++++++++
> .github/workflows/lint.yml | 20 ++++++++++++++++++++
> 2 files changed, 31 insertions(+)
> create mode 100644 .github/actions/checkpatch/action.yml
>
>diff --git a/.github/actions/checkpatch/action.yml b/.github/actions/checkpatch/action.yml
>new file mode 100644
>index 00000000..cd2cce62
>--- /dev/null
>+++ b/.github/actions/checkpatch/action.yml
>@@ -0,0 +1,11 @@
>+name: Setup checkpatch
>+description: Setup a script for checking for codestyle and grammar errors
>+runs:
>+ using: composite
>+ steps:
>+ - uses: actions/checkout@v3
>+ with:
>+ repository: tarantool/checkpatch
>+ path: 'checkpatch'
>+ - run: apt install -y codespell
>+ shell: bash
>diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
>index 8154a622..db3af975 100644
>--- a/.github/workflows/lint.yml
>+++ b/.github/workflows/lint.yml
>@@ -51,3 +51,23 @@ jobs:
> - name: luacheck
> run: cmake --build . --target LuaJIT-luacheck
> working-directory: ${{ env.BUILDDIR }}
>+
>+ checkpatch:
>+ runs-on: [self-hosted, lightweight, Linux, x86_64]
>+
>+ steps:
>+ - uses: actions/checkout@v3
>+ with:
>+ fetch-depth: 0
>+ submodules: recursive
>+ - name: checkpatch
>+ uses: ./.github/actions/checkpatch
>+ - name: environment
>+ uses: ./.github/actions/setup
>+ - name: make tarantool/master available
>+ run: git checkout tarantool/master && git checkout -
>+ - name: configure
>+ run: cmake -S . -B ${{ env.BUILDDIR }}
>+ - name: checkpatch
>+ run: cmake --build . --target LuaJIT-checkpatch
>+ working-directory: ${{ env.BUILDDIR }}
>--
>2.34.1
[-- Attachment #2: Type: text/html, Size: 2956 bytes --]
next prev parent reply other threads:[~2023-08-03 19:38 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-02 8:52 [Tarantool-patches] [PATCH 0/5][v3] Fix typos and " Sergey Bronnikov via Tarantool-patches
2023-08-02 8:52 ` [Tarantool-patches] [PATCH 1/5][v3] ci: fix a step name Sergey Bronnikov via Tarantool-patches
2023-08-03 19:27 ` Maxim Kokryashkin via Tarantool-patches
2023-08-09 11:20 ` Sergey Kaplun via Tarantool-patches
2023-08-02 8:52 ` [Tarantool-patches] [PATCH 2/5][v3] codehealth: fix typos Sergey Bronnikov via Tarantool-patches
2023-08-03 19:29 ` Maxim Kokryashkin via Tarantool-patches
2023-08-09 12:58 ` Sergey Kaplun via Tarantool-patches
2023-08-09 14:41 ` Sergey Bronnikov via Tarantool-patches
2023-08-02 8:52 ` [Tarantool-patches] [PATCH 3/5][v3] cmake: introduce new targets Sergey Bronnikov via Tarantool-patches
2023-08-03 19:38 ` Maxim Kokryashkin via Tarantool-patches
2023-08-04 10:56 ` Sergey Bronnikov via Tarantool-patches
2023-08-09 14:04 ` Sergey Kaplun via Tarantool-patches
2023-08-09 14:55 ` Sergey Bronnikov via Tarantool-patches
2023-08-09 15:45 ` Sergey Kaplun via Tarantool-patches
2023-08-15 8:57 ` Maxim Kokryashkin via Tarantool-patches
2023-08-02 8:52 ` [Tarantool-patches] [PATCH 4/5][v3] ci: enable checkpatch Sergey Bronnikov via Tarantool-patches
2023-08-03 19:38 ` Maxim Kokryashkin via Tarantool-patches [this message]
2023-08-09 14:40 ` Sergey Kaplun via Tarantool-patches
2023-08-09 15:05 ` Sergey Bronnikov via Tarantool-patches
2023-08-14 9:22 ` Sergey Bronnikov via Tarantool-patches
2023-08-02 8:52 ` [Tarantool-patches] [PATCH 5/5][v3] test: fix codestyle Sergey Bronnikov via Tarantool-patches
2023-08-03 19:45 ` Maxim Kokryashkin via Tarantool-patches
2023-08-04 10:42 ` Sergey Bronnikov via Tarantool-patches
2023-08-09 14:07 ` Sergey Kaplun via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1691091533.804781541@f148.i.mail.ru \
--to=tarantool-patches@dev.tarantool.org \
--cc=estetus@gmail.com \
--cc=m.kokryashkin@tarantool.org \
--cc=max.kokryashkin@gmail.com \
--subject='Re: [Tarantool-patches] [PATCH 4/5][v3] ci: enable checkpatch' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox