Re: [Tarantool-patches] [PATCH luajit 04/15] test: fix E203 errors by pycodestyle

[Maxim Kokryashkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

[-- Attachment #1: Type: text/plain, Size: 9121 bytes --]


Hi, Igor!
Thanks for the patch!
LGTM
--
Best regards,
Maxim Kokryashkin
 
 
> 
>>Fixed 36 occurrences of E203 ("whitespace before ':'") error reported
>>by pycodestyle[1]. Furthermore, many other parts have been re-aligned
>>the similar way to be in sync with the default code style.
>>
>>[1]:  https://www.flake8rules.com/rules/E203.html
>>
>>Signed-off-by: Igor Munkin < imun@tarantool.org >
>>---
>> src/luajit-gdb.py | 98 +++++++++++++++++++++----------------------
>> src/luajit_lldb.py | 102 ++++++++++++++++++++++-----------------------
>> 2 files changed, 100 insertions(+), 100 deletions(-)
>>
>>diff --git a/src/luajit-gdb.py b/src/luajit-gdb.py
>>index 198578b1..09899f58 100644
>>--- a/src/luajit-gdb.py
>>+++ b/src/luajit-gdb.py
>>@@ -65,20 +65,20 @@ def strx64(val):
>> # Types {{{
>> 
>> LJ_T = {
>>- 'NIL' : i2notu32(0),
>>- 'FALSE' : i2notu32(1),
>>- 'TRUE' : i2notu32(2),
>>- 'LIGHTUD' : i2notu32(3),
>>- 'STR' : i2notu32(4),
>>- 'UPVAL' : i2notu32(5),
>>- 'THREAD' : i2notu32(6),
>>- 'PROTO' : i2notu32(7),
>>- 'FUNC' : i2notu32(8),
>>- 'TRACE' : i2notu32(9),
>>- 'CDATA' : i2notu32(10),
>>- 'TAB' : i2notu32(11),
>>- 'UDATA' : i2notu32(12),
>>- 'NUMX' : i2notu32(13),
>>+ 'NIL': i2notu32(0),
>>+ 'FALSE': i2notu32(1),
>>+ 'TRUE': i2notu32(2),
>>+ 'LIGHTUD': i2notu32(3),
>>+ 'STR': i2notu32(4),
>>+ 'UPVAL': i2notu32(5),
>>+ 'THREAD': i2notu32(6),
>>+ 'PROTO': i2notu32(7),
>>+ 'FUNC': i2notu32(8),
>>+ 'TRACE': i2notu32(9),
>>+ 'CDATA': i2notu32(10),
>>+ 'TAB': i2notu32(11),
>>+ 'UDATA': i2notu32(12),
>>+ 'NUMX': i2notu32(13),
>> }
>> 
>> def typenames(value):
>>@@ -95,22 +95,22 @@ FRAME_P = 0x4
>> FRAME_TYPEP = FRAME_TYPE | FRAME_P
>> 
>> FRAME = {
>>- 'LUA': 0x0,
>>- 'C': 0x1,
>>- 'CONT': 0x2,
>>- 'VARG': 0x3,
>>- 'LUAP': 0x4,
>>- 'CP': 0x5,
>>- 'PCALL': 0x6,
>>+ 'LUA': 0x0,
>>+ 'C': 0x1,
>>+ 'CONT': 0x2,
>>+ 'VARG': 0x3,
>>+ 'LUAP': 0x4,
>>+ 'CP': 0x5,
>>+ 'PCALL': 0x6,
>>     'PCALLH': 0x7,
>> }
>> 
>> def frametypes(ft):
>>     return {
>>- FRAME['LUA'] : 'L',
>>- FRAME['C'] : 'C',
>>- FRAME['CONT'] : 'M',
>>- FRAME['VARG'] : 'V',
>>+ FRAME['LUA']: 'L',
>>+ FRAME['C']: 'C',
>>+ FRAME['CONT']: 'M',
>>+ FRAME['VARG']: 'V',
>>     }.get(ft, '?')
>> 
>> def bc_a(ins):
>>@@ -299,12 +299,12 @@ def gcringlen(root):
>>         return 1 + gclistlen(gcnext(root), gcref(root))
>> 
>> gclen = {
>>- 'root': gclistlen,
>>- 'gray': gclistlen,
>>+ 'root': gclistlen,
>>+ 'gray': gclistlen,
>>     'grayagain': gclistlen,
>>- 'weak': gclistlen,
>>+ 'weak': gclistlen,
>>     # XXX: gc.mmudata is a ring-list.
>>- 'mmudata': gcringlen,
>>+ 'mmudata': gcringlen,
>> }
>> 
>> # The generator that implements frame iterator.
>>@@ -410,20 +410,20 @@ def dump_lj_invalid(tv):
>> # }}}
>> 
>> dumpers = {
>>- 'LJ_TNIL': dump_lj_tnil,
>>- 'LJ_TFALSE': dump_lj_tfalse,
>>- 'LJ_TTRUE': dump_lj_ttrue,
>>+ 'LJ_TNIL': dump_lj_tnil,
>>+ 'LJ_TFALSE': dump_lj_tfalse,
>>+ 'LJ_TTRUE': dump_lj_ttrue,
>>     'LJ_TLIGHTUD': dump_lj_tlightud,
>>- 'LJ_TSTR': dump_lj_tstr,
>>- 'LJ_TUPVAL': dump_lj_tupval,
>>- 'LJ_TTHREAD': dump_lj_tthread,
>>- 'LJ_TPROTO': dump_lj_tproto,
>>- 'LJ_TFUNC': dump_lj_tfunc,
>>- 'LJ_TTRACE': dump_lj_ttrace,
>>- 'LJ_TCDATA': dump_lj_tcdata,
>>- 'LJ_TTAB': dump_lj_ttab,
>>- 'LJ_TUDATA': dump_lj_tudata,
>>- 'LJ_TNUMX': dump_lj_tnumx,
>>+ 'LJ_TSTR': dump_lj_tstr,
>>+ 'LJ_TUPVAL': dump_lj_tupval,
>>+ 'LJ_TTHREAD': dump_lj_tthread,
>>+ 'LJ_TPROTO': dump_lj_tproto,
>>+ 'LJ_TFUNC': dump_lj_tfunc,
>>+ 'LJ_TTRACE': dump_lj_ttrace,
>>+ 'LJ_TCDATA': dump_lj_tcdata,
>>+ 'LJ_TTAB': dump_lj_ttab,
>>+ 'LJ_TUDATA': dump_lj_tudata,
>>+ 'LJ_TNUMX': dump_lj_tnumx,
>> }
>> 
>> def dump_tvalue(tvalue):
>>@@ -695,8 +695,8 @@ The command requires no args and dumps current VM and GC states
>>         g = G(L(None))
>>         gdb.write('{}\n'.format('\n'.join(
>>             map(lambda t: '{} state: {}'.format(*t), {
>>- 'VM': vm_state(g),
>>- 'GC': gc_state(g),
>>+ 'VM': vm_state(g),
>>+ 'GC': gc_state(g),
>>                 'JIT': jit_state(g),
>>             }.items())
>>         )))
>>@@ -785,13 +785,13 @@ def init(commands):
>> 
>> def load(event=None):
>>     init({
>>- 'lj-arch': LJDumpArch,
>>- 'lj-tv': LJDumpTValue,
>>- 'lj-str': LJDumpString,
>>- 'lj-tab': LJDumpTable,
>>+ 'lj-arch': LJDumpArch,
>>+ 'lj-tv': LJDumpTValue,
>>+ 'lj-str': LJDumpString,
>>+ 'lj-tab': LJDumpTable,
>>         'lj-stack': LJDumpStack,
>>         'lj-state': LJState,
>>- 'lj-gc': LJGC,
>>+ 'lj-gc': LJGC,
>>     })
>> 
>> load(None)
>>diff --git a/src/luajit_lldb.py b/src/luajit_lldb.py
>>index 2887723b..b9c8a0b9 100644
>>--- a/src/luajit_lldb.py
>>+++ b/src/luajit_lldb.py
>>@@ -88,8 +88,8 @@ class MetaStruct(type):
>> 
>>         def make_general(field, tp):
>>             builtin = {
>>- 'uint': 'unsigned',
>>- 'int': 'signed',
>>+ 'uint': 'unsigned',
>>+ 'int': 'signed',
>>                         'string': 'value',
>>                     }
>>             if tp in builtin.keys():
>>@@ -380,12 +380,12 @@ def gcringlen(root):
>>         return 1 + gclistlen(gcnext(root), gcref(root))
>> 
>> gclen = {
>>- 'root': gclistlen,
>>- 'gray': gclistlen,
>>+ 'root': gclistlen,
>>+ 'gray': gclistlen,
>>     'grayagain': gclistlen,
>>- 'weak': gclistlen,
>>+ 'weak': gclistlen,
>>     # XXX: gc.mmudata is a ring-list.
>>- 'mmudata': gcringlen,
>>+ 'mmudata': gcringlen,
>> }
>> 
>> def dump_gc(g):
>>@@ -582,37 +582,37 @@ def dump_lj_invalid(tv):
>>     return 'not valid type @ {}'.format(strx64(gcval(tv.gcr)))
>> 
>> dumpers = {
>>- 'LJ_TNIL': dump_lj_tnil,
>>- 'LJ_TFALSE': dump_lj_tfalse,
>>- 'LJ_TTRUE': dump_lj_ttrue,
>>+ 'LJ_TNIL': dump_lj_tnil,
>>+ 'LJ_TFALSE': dump_lj_tfalse,
>>+ 'LJ_TTRUE': dump_lj_ttrue,
>>     'LJ_TLIGHTUD': dump_lj_tlightud,
>>- 'LJ_TSTR': dump_lj_tstr,
>>- 'LJ_TUPVAL': dump_lj_tupval,
>>- 'LJ_TTHREAD': dump_lj_tthread,
>>- 'LJ_TPROTO': dump_lj_tproto,
>>- 'LJ_TFUNC': dump_lj_tfunc,
>>- 'LJ_TTRACE': dump_lj_ttrace,
>>- 'LJ_TCDATA': dump_lj_tcdata,
>>- 'LJ_TTAB': dump_lj_ttab,
>>- 'LJ_TUDATA': dump_lj_tudata,
>>- 'LJ_TNUMX': dump_lj_tnumx,
>>+ 'LJ_TSTR': dump_lj_tstr,
>>+ 'LJ_TUPVAL': dump_lj_tupval,
>>+ 'LJ_TTHREAD': dump_lj_tthread,
>>+ 'LJ_TPROTO': dump_lj_tproto,
>>+ 'LJ_TFUNC': dump_lj_tfunc,
>>+ 'LJ_TTRACE': dump_lj_ttrace,
>>+ 'LJ_TCDATA': dump_lj_tcdata,
>>+ 'LJ_TTAB': dump_lj_ttab,
>>+ 'LJ_TUDATA': dump_lj_tudata,
>>+ 'LJ_TNUMX': dump_lj_tnumx,
>> }
>> 
>> LJ_T = {
>>- 'NIL' : i2notu32(0),
>>- 'FALSE' : i2notu32(1),
>>- 'TRUE' : i2notu32(2),
>>- 'LIGHTUD' : i2notu32(3),
>>- 'STR' : i2notu32(4),
>>- 'UPVAL' : i2notu32(5),
>>- 'THREAD' : i2notu32(6),
>>- 'PROTO' : i2notu32(7),
>>- 'FUNC' : i2notu32(8),
>>- 'TRACE' : i2notu32(9),
>>- 'CDATA' : i2notu32(10),
>>- 'TAB' : i2notu32(11),
>>- 'UDATA' : i2notu32(12),
>>- 'NUMX' : i2notu32(13),
>>+ 'NIL': i2notu32(0),
>>+ 'FALSE': i2notu32(1),
>>+ 'TRUE': i2notu32(2),
>>+ 'LIGHTUD': i2notu32(3),
>>+ 'STR': i2notu32(4),
>>+ 'UPVAL': i2notu32(5),
>>+ 'THREAD': i2notu32(6),
>>+ 'PROTO': i2notu32(7),
>>+ 'FUNC': i2notu32(8),
>>+ 'TRACE': i2notu32(9),
>>+ 'CDATA': i2notu32(10),
>>+ 'TAB': i2notu32(11),
>>+ 'UDATA': i2notu32(12),
>>+ 'NUMX': i2notu32(13),
>> }
>> 
>> def itypemap(o):
>>@@ -635,22 +635,22 @@ FRAME_P = 0x4
>> FRAME_TYPEP = FRAME_TYPE | FRAME_P
>> 
>> FRAME = {
>>- 'LUA': 0x0,
>>- 'C': 0x1,
>>- 'CONT': 0x2,
>>- 'VARG': 0x3,
>>- 'LUAP': 0x4,
>>- 'CP': 0x5,
>>- 'PCALL': 0x6,
>>+ 'LUA': 0x0,
>>+ 'C': 0x1,
>>+ 'CONT': 0x2,
>>+ 'VARG': 0x3,
>>+ 'LUAP': 0x4,
>>+ 'CP': 0x5,
>>+ 'PCALL': 0x6,
>>     'PCALLH': 0x7,
>> }
>> 
>> def frametypes(ft):
>>     return {
>>- FRAME['LUA'] : 'L',
>>- FRAME['C'] : 'C',
>>- FRAME['CONT'] : 'M',
>>- FRAME['VARG'] : 'V',
>>+ FRAME['LUA']: 'L',
>>+ FRAME['C']: 'C',
>>+ FRAME['CONT']: 'M',
>>+ FRAME['VARG']: 'V',
>>     }.get(ft, '?')
>> 
>> def bc_a(ins):
>>@@ -838,8 +838,8 @@ The command requires no args and dumps current VM and GC states
>>         g = G(L(None))
>>         print('{}'.format('\n'.join(
>>             map(lambda t: '{} state: {}'.format(*t), {
>>- 'VM': vm_state(g),
>>- 'GC': gc_state(g),
>>+ 'VM': vm_state(g),
>>+ 'GC': gc_state(g),
>>                 'JIT': jit_state(g),
>>             }.items())
>>         )))
>>@@ -1024,12 +1024,12 @@ def configure(debugger):
>> def __lldb_init_module(debugger, internal_dict):
>>     configure(debugger)
>>     register_commands(debugger, {
>>- 'lj-tv': LJDumpTValue,
>>+ 'lj-tv': LJDumpTValue,
>>         'lj-state': LJState,
>>- 'lj-arch': LJDumpArch,
>>- 'lj-gc': LJGC,
>>- 'lj-str': LJDumpString,
>>- 'lj-tab': LJDumpTable,
>>+ 'lj-arch': LJDumpArch,
>>+ 'lj-gc': LJGC,
>>+ 'lj-str': LJDumpString,
>>+ 'lj-tab': LJDumpTable,
>>         'lj-stack': LJDumpStack,
>>     })
>>     print('luajit_lldb.py is successfully loaded')
>>--
>>2.30.2
> 

[-- Attachment #2: Type: text/html, Size: 11804 bytes --]