Re: [Tarantool-patches] [PATCH luajit 03/15] test: fix E201 and E202 errors by pycodestyle

[Maxim Kokryashkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

[-- Attachment #1: Type: text/plain, Size: 4043 bytes --]


Hi, Igor!
Thanks for the patch!
LGTM
--
Best regards,
Maxim Kokryashkin
 
 
> 
>>Fixed the only occurrence of E202 ("whitespace before ')'"), 7
>>occurrences of E201 ("whitespace after '['") and 7 occurrences of E202
>>("whitespace before ']'") errors reported by pycodestyle[1][2].
>>
>>[1]:  https://www.flake8rules.com/rules/E201.html
>>[2]:  https://www.flake8rules.com/rules/E202.html
>>
>>Signed-off-by: Igor Munkin < imun@tarantool.org >
>>---
>> src/luajit-gdb.py | 14 +++++++-------
>> src/luajit_lldb.py | 12 ++++++------
>> 2 files changed, 13 insertions(+), 13 deletions(-)
>>
>>diff --git a/src/luajit-gdb.py b/src/luajit-gdb.py
>>index b84fdc93..198578b1 100644
>>--- a/src/luajit-gdb.py
>>+++ b/src/luajit-gdb.py
>>@@ -195,7 +195,7 @@ def L(L=None):
>>     # lookup a symbol for the main coroutine considering the host app
>>     # XXX Fragile: though the loop initialization looks like a crap but it
>>     # respects both Python 2 and Python 3.
>>- for l in [ L ] + list(map(lambda l: lookup(l), (
>>+ for l in [L] + list(map(lambda l: lookup(l), (
>>         # LuaJIT main coro (see luajit/src/luajit.c)
>>         'globalL',
>>         # Tarantool main coro (see tarantool/src/lua/init.h)
>>@@ -504,20 +504,20 @@ def dump_stack(L, base=None, top=None):
>> 
>> def dump_gc(g):
>>     gc = g['gc']
>>- stats = [ '{key}: {value}'.format(key = f, value = gc[f]) for f in (
>>+ stats = ['{key}: {value}'.format(key = f, value = gc[f]) for f in (
>>         'total', 'threshold', 'debt', 'estimate', 'stepmul', 'pause'
>>- ) ]
>>+ )]
>> 
>>- stats += [ 'sweepstr: {sweepstr}/{strmask}'.format(
>>+ stats += ['sweepstr: {sweepstr}/{strmask}'.format(
>>         sweepstr = gc['sweepstr'],
>>         # String hash mask (size of hash table - 1).
>>         strmask = g['strmask'] + 1,
>>- ) ]
>>+ )]
>> 
>>- stats += [ '{key}: {number} objects'.format(
>>+ stats += ['{key}: {number} objects'.format(
>>         key = stat,
>>         number = handler(gc[stat])
>>- ) for stat, handler in gclen.items() ]
>>+ ) for stat, handler in gclen.items()]
>> 
>>     return '\n'.join(map(lambda s: '\t' + s, stats))
>> 
>>diff --git a/src/luajit_lldb.py b/src/luajit_lldb.py
>>index 3f636546..2887723b 100644
>>--- a/src/luajit_lldb.py
>>+++ b/src/luajit_lldb.py
>>@@ -211,7 +211,7 @@ c_structs = {
>> }
>> 
>> for cls in c_structs.keys():
>>- globals()[cls] = type(cls, (Struct, ), {'metainfo': c_structs[cls]} )
>>+ globals()[cls] = type(cls, (Struct, ), {'metainfo': c_structs[cls]})
>> 
>> for cls in Struct.__subclasses__():
>>     ptr_name = cls.__name__ + 'Ptr'
>>@@ -394,16 +394,16 @@ def dump_gc(g):
>>         'total', 'threshold', 'debt', 'estimate', 'stepmul', 'pause'
>>     )]
>> 
>>- stats += [ 'sweepstr: {sweepstr}/{strmask}'.format(
>>+ stats += ['sweepstr: {sweepstr}/{strmask}'.format(
>>         sweepstr = gc.sweepstr,
>>         # String hash mask (size of hash table - 1).
>>         strmask = g.strmask + 1,
>>- ) ]
>>+ )]
>> 
>>- stats += [ '{key}: {number} objects'.format(
>>+ stats += ['{key}: {number} objects'.format(
>>         key = stat,
>>         number = handler(getattr(gc, stat))
>>- ) for stat, handler in gclen.items() ]
>>+ ) for stat, handler in gclen.items()]
>>     return '\n'.join(map(lambda s: '\t' + s, stats))
>> 
>> def mref(typename, obj):
>>@@ -424,7 +424,7 @@ def L(L=None):
>>     # lookup a symbol for the main coroutine considering the host app
>>     # XXX Fragile: though the loop initialization looks like a crap but it
>>     # respects both Python 2 and Python 3.
>>- for l in [ L ] + list(map(lambda l: lookup_global(l), (
>>+ for l in [L] + list(map(lambda l: lookup_global(l), (
>>         # LuaJIT main coro (see luajit/src/luajit.c)
>>         'globalL',
>>         # Tarantool main coro (see tarantool/src/lua/init.h)
>>--
>>2.30.2
> 

[-- Attachment #2: Type: text/html, Size: 5809 bytes --]