Tarantool development patches archive
 help / color / mirror / Atom feed
From: Maxim Kokryashkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: "Sergey Bronnikov" <estetus@gmail.com>
Cc: max.kokryashkin@gmail.com, tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches]  [PATCH 1/4][v2] ci: fix a step name
Date: Mon, 17 Jul 2023 18:43:15 +0300	[thread overview]
Message-ID: <1689608595.660894245@f380.i.mail.ru> (raw)
In-Reply-To: <58508c06a573751a79757628a8c302a89c5f4296.1689600525.git.sergeyb@tarantool.org>

[-- Attachment #1: Type: text/plain, Size: 1056 bytes --]


Hi!
Thanks for the patch!
LGTM, however, I strongly discourage addition of
non-relevant changes to the series.
--
Best regards,
Maxim Kokryashkin
 
  
>Понедельник, 17 июля 2023, 16:37 +03:00 от Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>:
> 
>From: Sergey Bronnikov < sergeyb@tarantool.org >
>
>Fixed an incorrect name in a github actions step.
>---
> .github/workflows/lint.yml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
>index 71ceee9a..44338f6d 100644
>--- a/.github/workflows/lint.yml
>+++ b/.github/workflows/lint.yml
>@@ -50,6 +50,6 @@ jobs:
>           echo CMAKE_BUILD_PARALLEL_LEVEL=$(($(nproc) + 1)) | tee -a $GITHUB_ENV
>       - name: configure
>         run: cmake -S . -B ${{ env.BUILDDIR }} -G Ninja
>- - name: test
>+ - name: luacheck
>         run: cmake --build . --target LuaJIT-luacheck
>         working-directory: ${{ env.BUILDDIR }}
>--
>2.34.1
 

[-- Attachment #2: Type: text/html, Size: 1781 bytes --]

  reply	other threads:[~2023-07-17 15:43 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-17 13:34 [Tarantool-patches] [PATCH 0/4][v2] Fix typos and enable checkpatch Sergey Bronnikov via Tarantool-patches
2023-07-17 13:34 ` [Tarantool-patches] [PATCH 1/4][v2] ci: fix a step name Sergey Bronnikov via Tarantool-patches
2023-07-17 15:43   ` Maxim Kokryashkin via Tarantool-patches [this message]
2023-07-17 13:34 ` [Tarantool-patches] [PATCH 2/4][v2] codehealth: fix typos Sergey Bronnikov via Tarantool-patches
2023-07-17 15:48   ` Maxim Kokryashkin via Tarantool-patches
2023-07-17 13:34 ` [Tarantool-patches] [PATCH 3/4][v2] cmake: introduce 'check' and 'LuaJIT-checkpatch' targets Sergey Bronnikov via Tarantool-patches
2023-07-17 16:10   ` Maxim Kokryashkin via Tarantool-patches
2023-07-20 18:07     ` Sergey Bronnikov via Tarantool-patches
2023-07-20 21:13       ` Maxim Kokryashkin via Tarantool-patches
2023-07-17 13:34 ` [Tarantool-patches] [PATCH 4/4][v2] ci: enable checkpatch Sergey Bronnikov via Tarantool-patches
2023-07-17 18:48   ` Maxim Kokryashkin via Tarantool-patches
2023-07-20 18:14     ` Sergey Bronnikov via Tarantool-patches
2023-07-20 21:14       ` Maxim Kokryashkin via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1689608595.660894245@f380.i.mail.ru \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=estetus@gmail.com \
    --cc=m.kokryashkin@tarantool.org \
    --cc=max.kokryashkin@gmail.com \
    --subject='Re: [Tarantool-patches]  [PATCH 1/4][v2] ci: fix a step name' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox