Re: [Tarantool-patches] [PATCH luajit v2] test: adapt disabled tests from PUC-Rio

[Maxim Kokryashkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

[-- Attachment #1: Type: text/plain, Size: 2912 bytes --]


Hi!
Thanks for the review!
Here is the new commit message:
======================================================
test: adapt disabled tests from PUC-Rio
 
Version and status are printed in stdout instead of stderr
since LuaJIT-2.0.0-beta11 (as it is not an error message). This behavior
is the same as in Lua 5.2, so necessary changes in tests can be
adapted from PUC-Rio Lua 5.2 test suite.
 
However, those tests are disabled for Tarantool since its interactive
shell doesn't support '=' at the beginning of statements.
Here is an example:
| $ luajit
| > = (6*2-6) -- ===
| 6
|
| $ tarantool
| tarantool> = (6*2-6) -- ===
| ---
| - error: ' (6*2-6) -- ===:1: unexpected symbol near ''='''
| ...
 
Resolves tarantool/tarantool#5687
Part of tarantool/tarantool#5870
======================================================
 
And here is the diff:
======================================================
diff --git a/test/PUC-Rio-Lua-5.1-tests/main.lua b/test/PUC-Rio-Lua-5.1-tests/main.lua
index 9c1e5fa4..9894f299 100644
--- a/test/PUC-Rio-Lua-5.1-tests/main.lua
+++ b/test/PUC-Rio-Lua-5.1-tests/main.lua
@@ -34,8 +34,8 @@ function getoutput ()
   return t
 end
 
--- Version and status are printed in stdout instead stderr since
--- LuaJIT-2.0.0-beta11 (as it is not an error message).
+-- Version and status are printed in stdout instead of stderr
+-- since LuaJIT-2.0.0-beta11 (as it is not an error message).
 -- See commit 0bd1a66f2f055211ef55834ccebca3b82d03c735
 -- (Print version and JIT status to stdout, not stderr.).
 -- This behavior is the same as in Lua 5.2.
======================================================
--
Best regards,
Maxim Kokryashkin
 
  
>Среда, 16 февраля 2022, 13:41 +03:00 от Igor Munkin <imun@tarantool.org>:
> 
>Sergey,
>
>On 16.12.21, Sergey Kaplun wrote:
>> Hi, Maxim!
>>
>> Thanks for the fixes!
>>
>> LGTM, except a few nits below.
>>
>> On 13.10.21, Maxim Kokryashkin wrote:
>> > Version and status are printed in stdout instead stderr
>> > since LuaJIT-2.0.0-beta11 (as it is not an error message). This behavior
>> > is the same as in Lua 5.2, so necessary changes in tests can be
>> > adapted from PUC-Rio Lua 5.2 test suite.
>> >
>> > However, those tests are disabled for Tarantool since its interactive
>> > shell doesn't support '=' at the beginning of statements.
>> > Here is an example:
>>
>> OK, so maybe we should create a ticket for that (and _PROMPT feature)?
>> At least to mention it and wait for thumbs up.
>> Igor, thoughts?
>
>I guess this is not an obligatory feature, since nobody claims Tarantool
>console should provide the similar interfaces LuaJIT does. IMHO, the
>best solution for this would be LuaJIT compatibility flag for Tarantool
>or its console, but I see no demand for this. So, it's up to you to file
>a ticket or not.
>
>>
>
><snipped>
>
>>
>> --
>> Best regards,
>> Sergey Kaplun
>
>--
>Best regards,
>IM
 

[-- Attachment #2: Type: text/html, Size: 4086 bytes --]