Tarantool development patches archive
 help / color / mirror / Atom feed
From: Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Kaplun <skaplun@tarantool.org>,
	Sergey Bronnikov <estetus@gmail.com>,
	tarantool-patches@dev.tarantool.org, max.kokryashkin@gmail.com
Subject: Re: [Tarantool-patches] [PATCH luajit 3/4][v2] cmake: introduce target with codespell
Date: Tue, 31 Oct 2023 13:50:50 +0300	[thread overview]
Message-ID: <161aa6ec-113b-4f60-be05-89314a612510@tarantool.org> (raw)
In-Reply-To: <ZUCh7LKf0O0FowXg@root>

Hello,

On 10/31/23 09:42, Sergey Kaplun wrote:
> Hi, Sergey!
> One more comment below:
>
<snipped>
> --- a/cmake/CodeSpell.cmake
> +++ b/cmake/CodeSpell.cmake
> @@ -1,13 +1,25 @@
>    find_program(CODESPELL codespell)
>
>    string(JOIN "," CODESPELL_WHITELIST
> +  ${PROJECT_SOURCE_DIR}/src/lib_misc.c
>      ${PROJECT_SOURCE_DIR}/src/lj_mapi.c
> +  ${PROJECT_SOURCE_DIR}/src/lj_memprof.c
> +  ${PROJECT_SOURCE_DIR}/src/lj_memprof.h
>      ${PROJECT_SOURCE_DIR}/src/lj_sysprof.c
> +  ${PROJECT_SOURCE_DIR}/src/lj_sysprof.h
> +  ${PROJECT_SOURCE_DIR}/src/lj_utils.h
>      ${PROJECT_SOURCE_DIR}/src/lj_utils_leb128.c
>      ${PROJECT_SOURCE_DIR}/src/lj_wbuf.c
> +  ${PROJECT_SOURCE_DIR}/src/lj_wbuf.h
> +  ${PROJECT_SOURCE_DIR}/src/lmisclib.h
>      ${PROJECT_SOURCE_DIR}/src/luajit-gdb.py
>      ${PROJECT_SOURCE_DIR}/src/luajit_lldb.py
>      ${PROJECT_SOURCE_DIR}/test/CMakeLists.txt
> +  ${PROJECT_SOURCE_DIR}/test/lua-Harness-tests/CMakeLists.txt
> +  ${PROJECT_SOURCE_DIR}/test/LuaJIT-tests/CMakeLists.txt
> +  ${PROJECT_SOURCE_DIR}/test/PUC-Rio-Lua-5.1-tests/CMakeLists.txt
> +  ${PROJECT_SOURCE_DIR}/test/PUC-Rio-Lua-5.1-tests/CMakeLists.txt
> + ${PROJECT_SOURCE_DIR}/test/PUC-Rio-Lua-5.1-tests/libs/CMakeLists.txt
>      ${PROJECT_SOURCE_DIR}/test/tarantool-c-tests
>      ${PROJECT_SOURCE_DIR}/test/tarantool-tests
>      ${PROJECT_SOURCE_DIR}/tools
>> Side note: within vim's (sort 'l' is greater then 'L', see `man ascii`),
>> but I'm OK with this order too.
> Sorry, I've forgot about <src/lj_symtab.c> <src/lj_symtab.h>.

Added:

--- a/cmake/CodeSpell.cmake
+++ b/cmake/CodeSpell.cmake
@@ -5,6 +5,8 @@ string(JOIN "," CODESPELL_WHITELIST
    ${PROJECT_SOURCE_DIR}/src/lj_mapi.c
    ${PROJECT_SOURCE_DIR}/src/lj_memprof.c
    ${PROJECT_SOURCE_DIR}/src/lj_memprof.h
+  ${PROJECT_SOURCE_DIR}/src/lj_symtab.c
+  ${PROJECT_SOURCE_DIR}/src/lj_symtab.h
    ${PROJECT_SOURCE_DIR}/src/lj_sysprof.c
    ${PROJECT_SOURCE_DIR}/src/lj_sysprof.h
    ${PROJECT_SOURCE_DIR}/src/lj_utils.h

>

  reply	other threads:[~2023-10-31 10:50 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-11 16:52 [Tarantool-patches] [PATCH luajit 0/4][v2] Fix typos and enable codespell Sergey Bronnikov via Tarantool-patches
2023-10-11 16:52 ` [Tarantool-patches] [PATCH luajit 1/4][v2] codehealth: fix typos Sergey Bronnikov via Tarantool-patches
2023-10-12 10:33   ` Maxim Kokryashkin via Tarantool-patches
2023-10-23  8:50   ` Sergey Kaplun via Tarantool-patches
2023-10-11 16:52 ` [Tarantool-patches] [PATCH luajit 2/4][v2] test: fix codestyle Sergey Bronnikov via Tarantool-patches
2023-10-12 10:34   ` Maxim Kokryashkin via Tarantool-patches
2023-10-23  8:52   ` Sergey Kaplun via Tarantool-patches
2023-10-23 14:13     ` Sergey Bronnikov via Tarantool-patches
2023-10-23 14:27       ` Sergey Kaplun via Tarantool-patches
2023-10-11 16:52 ` [Tarantool-patches] [PATCH luajit 3/4][v2] cmake: introduce target with codespell Sergey Bronnikov via Tarantool-patches
2023-10-11 19:33   ` Sergey Bronnikov via Tarantool-patches
2023-10-12 10:43   ` Maxim Kokryashkin via Tarantool-patches
2023-10-12 13:28     ` Sergey Bronnikov via Tarantool-patches
2023-10-12 18:46       ` Maxim Kokryashkin via Tarantool-patches
2023-10-17 14:50         ` Sergey Bronnikov via Tarantool-patches
2023-10-23  9:20   ` Sergey Kaplun via Tarantool-patches
2023-10-23 12:29     ` Sergey Bronnikov via Tarantool-patches
2023-10-23 14:38       ` Sergey Kaplun via Tarantool-patches
2023-10-31  6:42         ` Sergey Kaplun via Tarantool-patches
2023-10-31 10:50           ` Sergey Bronnikov via Tarantool-patches [this message]
2023-10-31 11:31             ` Sergey Kaplun via Tarantool-patches
2023-10-31 11:53             ` Maxim Kokryashkin via Tarantool-patches
2023-10-11 16:52 ` [Tarantool-patches] [PATCH luajit 4/4][v2] ci: enable codespell Sergey Bronnikov via Tarantool-patches
2023-10-12 10:45   ` Maxim Kokryashkin via Tarantool-patches
2023-10-23  8:53   ` Sergey Kaplun via Tarantool-patches
2023-11-16 16:19 ` [Tarantool-patches] [PATCH luajit 0/4][v2] Fix typos and " Igor Munkin via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=161aa6ec-113b-4f60-be05-89314a612510@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=estetus@gmail.com \
    --cc=max.kokryashkin@gmail.com \
    --cc=sergeyb@tarantool.org \
    --cc=skaplun@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH luajit 3/4][v2] cmake: introduce target with codespell' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox