From: Georgy Kirichenko <georgy@tarantool.org> To: tarantool-patches@freelists.org Cc: Konstantin Osipov <kostja@tarantool.org> Subject: [tarantool-patches] Re: [PATCH v3 1/2] Write rows without a lsn to the transaction tail Date: Mon, 11 Mar 2019 13:54:03 +0300 [thread overview] Message-ID: <1611415.TB3NjmJXjb@localhost> (raw) In-Reply-To: <20190311095926.GA9866@chai> [-- Attachment #1: Type: text/plain, Size: 2008 bytes --] On Monday, March 11, 2019 12:59:26 PM MSK Konstantin Osipov wrote: > * Georgy Kirichenko <georgy@tarantool.org> [19/03/11 09:55]: > > Form a separate transaction with local changes in case of replication. > > This is important because we should be able to replicate such changes > > (e.g. made within an on_replace trigger) back. In the opposite case > > local changes will be incorporated into originating transaction and > > would be skipped by the originator replica. > > I wonder will we possibly have some recovery issues, since in fact > we're performing a reordering of execution here? > > Imagine local and remote statements change the same set of rows. > During initial execution these changes are intermixed, during > recovery they are serialized. If you remember we were agreed that only local spaces are allowed to change in case of replication triggers. > > It seems we clearly have a problem here. We can either open a bug, > support multiple txn ids in the same stream, support multiple > server ids in the same transaction, ban triggers in > multi-statement transaction? You pushed me to remove txn_replica_id but it was one of the instruments I planed to use in order to support distributed transactions (with multiple replica ids in the same transaction) in the future. So I would prefer if we just disable changing of non-local spaces during replication. In such case we won't have any issues with reordering. > > Can we attribute local changes to the same server id? It is impossible because of lsn > We don't have to replicate them back - this is a gray zone and we can do it > in any way we want. I'm afraid no because we already have this functionality and it is even covered with tests. So we have to make a high level decision: what is expected behavior. In any case I will be agreed with your decision what we should to do: disable non-local replication changes, change behavior of replication for such changes or start further distributed transaction investigation. [-- Attachment #2: This is a digitally signed message part. --] [-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-03-11 10:54 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-03-10 20:21 [tarantool-patches] [PATCH v3 0/2] Transaction boundaries for applier Georgy Kirichenko 2019-03-10 20:21 ` [tarantool-patches] [PATCH] Don't free fiber gc on while txn_rollback Georgy Kirichenko 2019-03-11 8:12 ` [tarantool-patches] " Konstantin Osipov 2019-03-10 20:21 ` [tarantool-patches] [PATCH v3 1/2] Write rows without a lsn to the transaction tail Georgy Kirichenko 2019-03-11 8:14 ` [tarantool-patches] " Konstantin Osipov 2019-03-11 8:40 ` [tarantool-patches] " Vladimir Davydov 2019-03-11 9:59 ` [tarantool-patches] " Konstantin Osipov 2019-03-11 10:54 ` Georgy Kirichenko [this message] 2019-03-11 14:04 ` Konstantin Osipov 2019-03-11 19:52 ` Георгий Кириченко 2019-03-10 20:21 ` [tarantool-patches] [PATCH v3 2/2] Transaction support for applier Georgy Kirichenko 2019-03-11 8:18 ` [tarantool-patches] " Konstantin Osipov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1611415.TB3NjmJXjb@localhost \ --to=georgy@tarantool.org \ --cc=kostja@tarantool.org \ --cc=tarantool-patches@freelists.org \ --subject='[tarantool-patches] Re: [PATCH v3 1/2] Write rows without a lsn to the transaction tail' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox