From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Kirill Shcherbatov <kshcherbatov@tarantool.org>,
tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH v2 1/1] sql: support HAVING without GROUP BY clause
Date: Mon, 10 Dec 2018 17:23:47 +0300 [thread overview]
Message-ID: <160c2407-aff7-9f45-44de-01298021f370@tarantool.org> (raw)
In-Reply-To: <a5ca7201-7b45-3b97-ddb9-93216a4682a2@tarantool.org>
Hi! Thanks for the fixes!
On 04/12/2018 13:44, Kirill Shcherbatov wrote:
> Hi! Thank you for comments:
>> 1. Please, add an example and a reference to a standard (I've
>> found more strict description in 2011 SQL standard
>> "Part 2: Foundation" on 403 page).
> Appended to the end of @TarantoolBot document:
>
> 2011 SQL standard "Part 2: Foundation" 7.10 <having clause> p.381
> Example:
> SELECT MIN(s1) FROM te40 HAVING SUM(s1) > 0; -- is valid
> SELECT 1 FROM te40 HAVING SUM(s1) > 0; -- is valid
> SELECT NULL FROM te40 HAVING SUM(s1) > 0; -- is valid
> SELECT date() FROM te40 HAVING SUM(s1) > 0; -- is valid
>
>> 2. Why do you need sql_expr_is_literal() and sql_expr_is_constant_func()
>> if you have sqlite3ExprIsConstantOrFunction() ?
> Yep, good idea; didn't know that such function already exists
>
On the branch I still see my commit with review fixes and
your old implementation. Please, push a new version.
next prev parent reply other threads:[~2018-12-10 14:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-29 14:33 [tarantool-patches] " Kirill Shcherbatov
2018-11-30 17:22 ` [tarantool-patches] " Vladislav Shpilevoy
2018-11-30 17:32 ` Kirill Shcherbatov
2018-12-03 20:45 ` Vladislav Shpilevoy
[not found] ` <a5ca7201-7b45-3b97-ddb9-93216a4682a2@tarantool.org>
2018-12-10 14:23 ` Vladislav Shpilevoy [this message]
[not found] ` <61be199c-a233-aac3-18ee-fa64c908126d@tarantool.org>
2018-12-25 12:59 ` Kirill Shcherbatov
2018-12-28 14:39 ` n.pettik
2018-12-26 11:19 ` Vladislav Shpilevoy
2018-12-29 14:58 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=160c2407-aff7-9f45-44de-01298021f370@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=kshcherbatov@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH v2 1/1] sql: support HAVING without GROUP BY clause' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox