Re: [Tarantool-patches] [PATCH v9 6/7] txn: txn_add_redo -- drop synchro processing

["Serge Petrenko" <sergepetrenko@tarantool.org>]

[-- Attachment #1: Type: text/plain, Size: 1190 bytes --]


LGTM.
 
 
  
>Четверг, 20 августа 2020, 0:36 +03:00 от Cyrill Gorcunov <gorcunov@gmail.com>:
> 
>Since we no longer use txn engine for synchro
>packets processing this code is never executed.
>
>Part-of #5129
>
>Signed-off-by: Cyrill Gorcunov < gorcunov@gmail.com >
>---
> src/box/txn.c | 9 +--------
> 1 file changed, 1 insertion(+), 8 deletions(-)
>
>diff --git a/src/box/txn.c b/src/box/txn.c
>index cc1f496c5..b2d342355 100644
>--- a/src/box/txn.c
>+++ b/src/box/txn.c
>@@ -82,14 +82,7 @@ txn_add_redo(struct txn *txn, struct txn_stmt *stmt, struct request *request)
>  */
>  struct space *space = stmt->space;
>  row->group_id = space != NULL ? space_group_id(space) : 0;
>- /*
>- * Sychronous replication entries are supplementary and
>- * aren't valid dml requests. They're encoded manually.
>- */
>- if (likely(!iproto_type_is_synchro_request(row->type)))
>- row->bodycnt = xrow_encode_dml(request, &txn->region, row->body);
>- else
>- row->bodycnt = xrow_header_dup_body(row, &txn->region);
>+ row->bodycnt = xrow_encode_dml(request, &txn->region, row->body);
>  if (row->bodycnt < 0)
>  return -1;
>  stmt->row = row;
>--
>2.26.2
--
Serge Petrenko
 

[-- Attachment #2: Type: text/html, Size: 1753 bytes --]