Re: [Tarantool-patches] [PATCH v9 2/7] journal: add journal_entry_create helper

["Serge Petrenko" <sergepetrenko@tarantool.org>]

[-- Attachment #1: Type: text/plain, Size: 1619 bytes --]


Thanks for the patch! LGTM.
  
>Четверг, 20 августа 2020, 0:35 +03:00 от Cyrill Gorcunov <gorcunov@gmail.com>:
> 
>To create raw journal entries. We will use it
>to write confirm/rollback entries.
>
>Part-of #5129
>
>Signed-off-by: Cyrill Gorcunov < gorcunov@gmail.com >
>---
> src/box/journal.c | 8 ++------
> src/box/journal.h | 16 ++++++++++++++++
> 2 files changed, 18 insertions(+), 6 deletions(-)
>
>diff --git a/src/box/journal.c b/src/box/journal.c
>index 48af9157b..cb320b557 100644
>--- a/src/box/journal.c
>+++ b/src/box/journal.c
>@@ -51,11 +51,7 @@ journal_entry_new(size_t n_rows, struct region *region,
>  return NULL;
>  }
> 
>- entry->write_async_cb = write_async_cb;
>- entry->complete_data = complete_data;
>- entry->approx_len = 0;
>- entry->n_rows = n_rows;
>- entry->res = -1;
>-
>+ journal_entry_create(entry, n_rows, 0, write_async_cb,
>+ complete_data);
>  return entry;
> }
>diff --git a/src/box/journal.h b/src/box/journal.h
>index 4b019fecf..5d8d5a726 100644
>--- a/src/box/journal.h
>+++ b/src/box/journal.h
>@@ -83,6 +83,22 @@ struct journal_entry {
> 
> struct region;
> 
>+/**
>+ * Initialize a new journal entry.
>+ */
>+static inline void
>+journal_entry_create(struct journal_entry *entry, size_t n_rows,
>+ size_t approx_len,
>+ journal_write_async_f write_async_cb,
>+ void *complete_data)
>+{
>+ entry->write_async_cb = write_async_cb;
>+ entry->complete_data = complete_data;
>+ entry->approx_len = approx_len;
>+ entry->n_rows = n_rows;
>+ entry->res = -1;
>+}
>+
> /**
>  * Create a new journal entry.
>  *
>--
>2.26.2
 
--
Serge Petrenko
 

[-- Attachment #2: Type: text/html, Size: 2250 bytes --]