From: "Ilya Kosarev" <i.kosarev@tarantool.org>
To: "Aleksandr Lyapunov" <alyapunov@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2 2/3] alter: fix codestyle
Date: Tue, 04 Aug 2020 13:10:10 +0300 [thread overview]
Message-ID: <1596535810.142039609@f749.i.mail.ru> (raw)
In-Reply-To: <1594649887-15890-3-git-send-email-alyapunov@tarantool.org>
[-- Attachment #1: Type: text/plain, Size: 703 bytes --]
As far as i see, there are more places in alter.cc with wrong
codestyle (spaces instead of tabs) but i guess those are the worst.
>Понедельник, 13 июля 2020, 17:18 +03:00 от Aleksandr Lyapunov <alyapunov@tarantool.org>:
>
>---
> src/box/alter.cc | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/src/box/alter.cc b/src/box/alter.cc
>index 15a51d0..9b2b8e8 100644
>--- a/src/box/alter.cc
>+++ b/src/box/alter.cc
>@@ -1660,8 +1660,8 @@ public:
> void
> UpdateSchemaVersion::alter(struct alter_space *alter) noexcept
> {
>- (void)alter;
>- ++schema_version;
>+ (void) alter;
>+ ++schema_version;
> }
>
> /**
>--
>2.7.4
>
--
Ilya Kosarev
[-- Attachment #2: Type: text/html, Size: 1215 bytes --]
next prev parent reply other threads:[~2020-08-04 10:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-13 14:18 [Tarantool-patches] [PATCH v2 0/3] Simplify alter.cc Aleksandr Lyapunov
2020-07-13 14:18 ` [Tarantool-patches] [PATCH v2 1/3] alter: use good c++ style Aleksandr Lyapunov
2020-08-04 9:55 ` Ilya Kosarev
2020-08-04 10:04 ` Ilya Kosarev
2020-07-13 14:18 ` [Tarantool-patches] [PATCH v2 2/3] alter: fix codestyle Aleksandr Lyapunov
2020-08-04 10:10 ` Ilya Kosarev [this message]
2020-07-13 14:18 ` [Tarantool-patches] [PATCH v2 3/3] alter: do not catch exceptions when it's not necessary Aleksandr Lyapunov
2020-07-13 18:34 ` Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1596535810.142039609@f749.i.mail.ru \
--to=i.kosarev@tarantool.org \
--cc=alyapunov@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2 2/3] alter: fix codestyle' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox