From: Aleksandr Lyapunov <alyapunov@tarantool.org>
To: tarantool-patches@dev.tarantool.org
Cc: v.shpilevoy@tarantool.org
Subject: [Tarantool-patches] [PATCH v2 0/3] Simplify alter.cc
Date: Mon, 13 Jul 2020 17:18:04 +0300 [thread overview]
Message-ID: <1594649887-15890-1-git-send-email-alyapunov@tarantool.org> (raw)
Since we use C++ we need to use in a way that benefits its advantages.
At least we should remove useless try-catch blocks.
GH issue: https://github.com/tarantool/tarantool/issues/5153
GH branch: https://github.com/tarantool/tarantool/tree/alyapunov/gh-5153-simplify-alter-cc
v2: after-CR fixes, remove function-try block.
Aleksandr Lyapunov (3):
alter: use good c++ style
alter: fix codestyle
alter: do not catch exceptions when it's not necessary
src/box/alter.cc | 192 +++++++++++++++++++++++++++----------------------------
1 file changed, 94 insertions(+), 98 deletions(-)
--
2.7.4
next reply other threads:[~2020-07-13 14:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-13 14:18 Aleksandr Lyapunov [this message]
2020-07-13 14:18 ` [Tarantool-patches] [PATCH v2 1/3] alter: use good c++ style Aleksandr Lyapunov
2020-08-04 9:55 ` Ilya Kosarev
2020-08-04 10:04 ` Ilya Kosarev
2020-07-13 14:18 ` [Tarantool-patches] [PATCH v2 2/3] alter: fix codestyle Aleksandr Lyapunov
2020-08-04 10:10 ` Ilya Kosarev
2020-07-13 14:18 ` [Tarantool-patches] [PATCH v2 3/3] alter: do not catch exceptions when it's not necessary Aleksandr Lyapunov
2020-07-13 18:34 ` Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1594649887-15890-1-git-send-email-alyapunov@tarantool.org \
--to=alyapunov@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2 0/3] Simplify alter.cc' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox